DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Patel, Rashmin N" <rashmin.n.patel@intel.com>
To: Navakanth M <navakanthdev@gmail.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"Cao, Waterman" <waterman.cao@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] vmxnet3 pmd dev restart
Date: Thu, 9 Oct 2014 22:06:30 +0000
Message-ID: <C68F1134885B32458704E1E4DA3E34F341A5E69B@FMSMSX105.amr.corp.intel.com> (raw)
In-Reply-To: <CAJuW35ib2CGvDvPctXPV6EkyLy-ZZuQ5sPSbGYYe8TbyDxwQeQ@mail.gmail.com>

I just quickly looked into the code and instead of releasing memory or simply set it to NULL (patch: 
 http://thread.gmane.org/gmane.comp.networking.dpdk.devel/4683), you can zero it out and it should work perfectly, you can give it a quick try.

memset(ring->buf_info, 0x0, ring->size*sizeof(vmxnet3_buf_info_t));

This will not free the memory from heap but just wipe it out to 0x0, provided that we freed all the mbuf(s) pointed by each buf_info->m pointers. Hence you won't need to reallocate it when you start device after this stop.


-----Original Message-----
From: Navakanth M [mailto:navakanthdev@gmail.com] 
Sent: Wednesday, October 08, 2014 10:11 PM
To: stephen@networkplumber.org; Patel, Rashmin N; Cao, Waterman
Cc: dev@dpdk.org
Subject: Re: vmxnet3 pmd dev restart

I had tried with Stephen's patch but after stop is done and when we call start it crashed at vmxnet3_dev_start()->
vmxnet3_dev_rxtx_init()->vmxnet3_post_rx_bufs() as buf_info is freed and is not allocated again. buf_info is allocated in
vmxnet3_dev_rx_queue_setup() which would be called once at the initialization only.
I also tried not freeing buf_info in stop but then i see different issue after start, packets are not received due to check while (rcd->gen == rxq->comp_ring.gen) { in vmxnet3_recv_pkts()

Waterman, Have you got chance to test stop and start of vmnet dev if so did you notice any issue similar to this?


On Thu, Oct 9, 2014 at 12:46 AM, Patel, Rashmin N <rashmin.n.patel@intel.com> wrote:
> Yes I had a local copy working with couple of lines fix. But someone else, I think Stephen added a fix patch for the same, and I assume if it's been merged, should be working, so did not follow up later.
> I don't have a VMware setup handy at moment but I think Waterman would have more information about testing that patch if he has found any issue with it.
> Thanks,
> Rashmin
> -----Original Message-----
> From: Navakanth M [mailto:navakanthdev@gmail.com]
> Sent: Wednesday, October 08, 2014 4:14 AM
> To: dev@dpdk.org; Patel, Rashmin N
> Subject: Re: vmxnet3 pmd dev restart
> Hi Rashmin
> I have come across your reply in following post that you have worked on this problem and would submit the patch for it.
> Can you please share information on the changes you worked on or patch log if you had submitted any for it?
> http://thread.gmane.org/gmane.comp.networking.dpdk.devel/4683
> Thanks
> Navakanth
> On Tue, Sep 30, 2014 at 1:44 PM, Navakanth M <navakanthdev@gmail.com> wrote:
>> Hi
>> I am using DPDKv1.7.0 running on Vmware Esxi 5.1 and am trying to 
>> reset the port which uses pmd_vmnet3 library functions from below 
>> function calls.
>> rte_eth_dev_stop
>> rte_eth_dev_start
>> Doing this, i face panic while rte_free(ring->buf_info) in 
>> Vmxnet3_cmd_ring_release().
>> I have gone through following thread but the patch mentioned didn't 
>> help rather it crashed in start function while accessing buf_info in 
>> vmxnet3_post_rx_bufs. I see this buf_info is allocated in queue setup 
>> functions which are called at initialization.
>> http://thread.gmane.org/gmane.comp.networking.dpdk.devel/4683
>> I tried not freeing it and then rx packets are not received due to 
>> mismatch in while (rcd->gen == rxq->comp_ring.gen) in
>> vmxnet3_recv_pkts()
>> To reset the device port, is this the right way what i am doing?
>> Or do I have to call vmxnet3_dev_tx_queue_setup()
>> vmxnet3_dev_rx_queue_setup() once stop is called? I have checked 
>> recent patches and threads but did not get much information on this.
>> Thanks
>> Navakanth

  reply	other threads:[~2014-10-09 21:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30  8:14 Navakanth M
2014-10-08 11:13 ` Navakanth M
2014-10-08 19:16   ` Patel, Rashmin N
2014-10-09  5:10     ` Navakanth M
2014-10-09 22:06       ` Patel, Rashmin N [this message]
2014-10-10  3:09         ` Cao, Waterman
2014-10-13  3:07           ` Navakanth M
2014-10-13 18:12             ` Patel, Rashmin N
2014-10-26  4:48               ` Navakanth M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C68F1134885B32458704E1E4DA3E34F341A5E69B@FMSMSX105.amr.corp.intel.com \
    --to=rashmin.n.patel@intel.com \
    --cc=dev@dpdk.org \
    --cc=navakanthdev@gmail.com \
    --cc=stephen@networkplumber.org \
    --cc=waterman.cao@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git