From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DF61DAE99 for ; Mon, 14 Apr 2014 15:14:08 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 14 Apr 2014 06:09:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,857,1389772800"; d="scan'208";a="512635359" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga001.fm.intel.com with ESMTP; 14 Apr 2014 06:14:07 -0700 Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 14 Apr 2014 14:12:44 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.224]) by IRSMSX154.ger.corp.intel.com ([163.33.192.96]) with mapi id 14.03.0123.003; Mon, 14 Apr 2014 14:12:44 +0100 From: "Burakov, Anatoly" To: David Marchand Thread-Topic: [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code Thread-Index: AQHPV+BhM3vrbSriC0ydfuq/aandUZsREsuw Date: Mon, 14 Apr 2014 13:12:44 +0000 Message-ID: References: <1397479912-4906-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1397479912-4906-1-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2014 13:14:09 -0000 Hi David, > For now, I have a problem with your patch as it breaks drivers that use > RTE_PCI_DRV_FORCE_UNBIND flag, since it removes the part where this flag > is handled. Besides, I can see some remaining parts mentioning > pci_switch_module() in comments. I wonder if this functionality is needed at all. I couldn't find any driver= s using that flag, and the unbinding can be done using the included Python = script as well. Given that we're getting rid of unbinding and binding in th= e EAL, it's only logical that we get rid of the force-unbinding as well, do= n't you think? Best regards, Anatoly Burakov DPDK SW Engineer -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare