DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code
Date: Mon, 14 Apr 2014 14:39:15 +0000	[thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E451236975927EEB6@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <534BEE72.4070205@6wind.com>

Hi David,

> This functionality is at least used by virtio-net-pmd.
> So we cannot remove this without a fix for virtio-net-pmd.

It appears that virtio-net-pmd hasn't been merged in yet? At least I can't see it in the git tree for 1.6 release.

> Yet, even if we remove this from the eal, I think we should provide a proper
> api to bind/unbind devices to kernel drivers.
> This way PMDs can use this api and forget about OS dependencies
> (linux/bsd).

Please forgive me for repeating myself, but I'm still not convinced that binding/unbinding the kernel drivers has to be the responsibility of the application in the first place. As far as I know, the reasons why the binding/unbinding code was there are purely historical and have no rationale behind them other than "this is how it was first implemented". Plus, correct me if I'm wrong, but FreeBSD has some issues with port binding/unbinding - i.e. it can't do that at all, at least during runtime, so on BSD it's even less of an issue.

Anyway, the reason I'm bringing this subject up in the first place is I'm preparing a patch to support VFIO driver alongside igb_uio. Among the changes I'm preparing to make is getting rid of the device ID list in igb_uio, so that any driver could be bound to it (via writing to new_id) - i.e. making it similar to how pci_stub, vfio-pci  et al work. A consequence of that will be that igb_uio won't try to bind any devices unless the user explicitly asks for it, meaning that the virtio device will not be bound to igb_uio by default. I think this will remedy the issues with virtio-net-pmd without the need for force-unbind logic in the EAL.

Best regards,
Anatoly Burakov
DPDK SW Engineer

--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare


 

  reply	other threads:[~2014-04-14 14:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 11:53 [dpdk-dev] [PATCH] Remove RTE_EAL_UNBIND_PORTS-related code Burakov, Anatoly
2014-04-14 12:51 ` [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code David Marchand
2014-04-14 12:51   ` [dpdk-dev] [PATCH 1/3] pci: pci_switch_module cleanup David Marchand
2014-04-15  8:39     ` Burakov, Anatoly
2014-04-14 12:51   ` [dpdk-dev] [PATCH 2/3] pci: move RTE_PCI_DRV_FORCE_UNBIND handling out of #ifdef David Marchand
2014-04-15  8:40     ` Burakov, Anatoly
2014-04-14 12:51   ` [dpdk-dev] [PATCH 3/3] pci: remove deprecated RTE_EAL_UNBIND_PORTS option David Marchand
2014-04-15  8:41     ` Burakov, Anatoly
2014-04-28 13:18     ` David Marchand
2014-04-14 13:12   ` [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code Burakov, Anatoly
2014-04-14 14:19     ` David Marchand
2014-04-14 14:39       ` Burakov, Anatoly [this message]
2014-04-15  8:15         ` Thomas Monjalon
2014-04-15  8:33           ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6ECDF3AB251BE4894318F4E451236975927EEB6@IRSMSX101.ger.corp.intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).