From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] pci: pci_switch_module cleanup
Date: Tue, 15 Apr 2014 08:39:49 +0000 [thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E45123697592853D7@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1397479912-4906-2-git-send-email-david.marchand@6wind.com>
> The pci_switch_module() function should only do what its name tells: unbind
> pci devices and rebind them on the specified kernel driver.
> Hence, it can not call pci_uio_map_resource().
>
> Call to pci_uio_map_resource() should be moved to
> rte_eal_pci_probe_one_driver() so that we can factorize code.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Best regards,
Anatoly Burakov
DPDK SW Engineer
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare
next prev parent reply other threads:[~2014-04-15 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 11:53 [dpdk-dev] [PATCH] Remove RTE_EAL_UNBIND_PORTS-related code Burakov, Anatoly
2014-04-14 12:51 ` [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code David Marchand
2014-04-14 12:51 ` [dpdk-dev] [PATCH 1/3] pci: pci_switch_module cleanup David Marchand
2014-04-15 8:39 ` Burakov, Anatoly [this message]
2014-04-14 12:51 ` [dpdk-dev] [PATCH 2/3] pci: move RTE_PCI_DRV_FORCE_UNBIND handling out of #ifdef David Marchand
2014-04-15 8:40 ` Burakov, Anatoly
2014-04-14 12:51 ` [dpdk-dev] [PATCH 3/3] pci: remove deprecated RTE_EAL_UNBIND_PORTS option David Marchand
2014-04-15 8:41 ` Burakov, Anatoly
2014-04-28 13:18 ` David Marchand
2014-04-14 13:12 ` [dpdk-dev] [PATCH 0/3] remove RTE_EAL_UNBIND_PORTS related code Burakov, Anatoly
2014-04-14 14:19 ` David Marchand
2014-04-14 14:39 ` Burakov, Anatoly
2014-04-15 8:15 ` Thomas Monjalon
2014-04-15 8:33 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6ECDF3AB251BE4894318F4E45123697592853D7@IRSMSX104.ger.corp.intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).