From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 90699AFD1 for ; Tue, 15 Apr 2014 10:40:08 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 15 Apr 2014 01:40:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="520724134" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 15 Apr 2014 01:39:52 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 15 Apr 2014 09:39:50 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.2]) by IRSMSX152.ger.corp.intel.com ([169.254.6.180]) with mapi id 14.03.0123.003; Tue, 15 Apr 2014 09:39:50 +0100 From: "Burakov, Anatoly" To: David Marchand Thread-Topic: [PATCH 1/3] pci: pci_switch_module cleanup Thread-Index: AQHPV+BZG96sNRuntk6yStJ3hhSoN5sSXCYQ Date: Tue, 15 Apr 2014 08:39:49 +0000 Message-ID: References: <1397479912-4906-1-git-send-email-david.marchand@6wind.com> <1397479912-4906-2-git-send-email-david.marchand@6wind.com> In-Reply-To: <1397479912-4906-2-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] pci: pci_switch_module cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2014 08:40:11 -0000 > The pci_switch_module() function should only do what its name tells: unbi= nd > pci devices and rebind them on the specified kernel driver. > Hence, it can not call pci_uio_map_resource(). >=20 > Call to pci_uio_map_resource() should be moved to > rte_eal_pci_probe_one_driver() so that we can factorize code. >=20 > Signed-off-by: David Marchand > --- Acked-by: Anatoly Burakov Best regards, Anatoly Burakov DPDK SW Engineer -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare