From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 896186895 for ; Wed, 21 May 2014 15:44:01 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 21 May 2014 06:40:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,880,1392192000"; d="scan'208";a="535456855" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga001.fm.intel.com with ESMTP; 21 May 2014 06:44:09 -0700 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 21 May 2014 14:44:09 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.249]) by IRSMSX151.ger.corp.intel.com ([163.33.192.59]) with mapi id 14.03.0123.003; Wed, 21 May 2014 14:44:08 +0100 From: "Burakov, Anatoly" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 05/16] Moved interrupt type out of igb_uio Thread-Index: AQHPc3pU/Cd31hHafECDpUBzZ8HkTZtK/DmAgAARE/A= Date: Wed, 21 May 2014 13:44:07 +0000 Message-ID: References: <1400514709-24087-6-git-send-email-anatoly.burakov@intel.com> <5003333.VJxjNhveko@xps13> In-Reply-To: <5003333.VJxjNhveko@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 05/16] Moved interrupt type out of igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 May 2014 13:44:02 -0000 Hi Thomas, > Why are you splitting things in 2 files? >=20 The commit message explains it. Initially this work was based off our inter= nal tree, which had a few virtio-related changes, including these two files= . I stripped out most of the virtio stuff and left only things relevant to = VFIO, but kept the file structure to make things easier for porting virtio = changes. > +#define RTE_INTR_MODE_MAX_MAX "max" >=20 > What is this constant for? That's a mistake, I'll remove it. Best regards, Anatoly Burakov DPDK SW Engineer