From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vfio: make container open error non-fatal
Date: Tue, 17 Jun 2014 08:52:05 +0000 [thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E451236976CC9C63B@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA36B94@IRSMSX103.ger.corp.intel.com>
Hi Bruce,
> The below patch is the quickest fix I found to make my applications work
> again, but I'm not sure it's the best solution. Can anyone else offer other
> suggestions to improve this?
Are you running things as root? If not, I suggest to try and use the setup.sh script to correct permissions on the VFIO container and see if it works.
The inability of opening a container is likely a problem with permissions on the container, and thus should be considered fatal as far as VFIO is concerned. However, given that we try to use VFIO unconditionally, I think your suggestion is a good solution to the problem, however I would also close the group fd's that were already opened before returning 1.
Best regards,
Anatoly Burakov
DPDK SW Engineer
next prev parent reply other threads:[~2014-06-17 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 22:29 Bruce Richardson
2014-06-16 22:30 ` Richardson, Bruce
2014-06-17 8:52 ` Burakov, Anatoly [this message]
2014-06-17 16:31 ` Richardson, Bruce
2014-06-17 8:56 ` Burakov, Anatoly
2014-06-17 10:57 ` Neil Horman
2014-06-17 16:53 ` Richardson, Bruce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6ECDF3AB251BE4894318F4E451236976CC9C63B@IRSMSX101.ger.corp.intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).