From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 14AE4AFDD
 for <dev@dpdk.org>; Wed, 18 Jun 2014 10:57:01 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 18 Jun 2014 01:51:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,499,1400050800"; d="scan'208";a="559444538"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga002.jf.intel.com with ESMTP; 18 Jun 2014 01:57:16 -0700
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.245]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.136]) with mapi id 14.03.0123.003;
 Wed, 18 Jun 2014 09:57:16 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather
 than during init
Thread-Index: AQHPikzmqXPLJ58Ywk2jfElMWsSSHZt2kG4A
Date: Wed, 18 Jun 2014 08:57:15 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236976CC9CB58@IRSMSX101.ger.corp.intel.com>
References: <4bf447650cc99e316e6427e3a1c134dd417af4ec.1402996488.git.anatoly.burakov@intel.com>
 <5481188.YHqy5HFYGY@xps13>
In-Reply-To: <5481188.YHqy5HFYGY@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather
 than during init
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jun 2014 08:57:02 -0000

Hi Thomas,

> Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rath=
er
> than during init
>=20
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>=20
> Please Anatoly, could you provide a text explaining what was broken and
> why you fixed it this way?

What was broken was if, for some reason, VFIO is loaded but the user can't =
initialize it (an example would be wrong permissions, or unsupported IOMMU =
type, which is what Bruce seems to be having... which shouldn't happen as f=
ar as I know, but there's nothing I can do on DPDK's side to fix this as th=
is is the kernel reporting wrong kind of IOMMU type), DPDK would fail to lo=
ad. The fix makes DPDK simply not try VFIO support at all if the container =
cannot be opened for some reason.

Best regards,
Anatoly Burakov
DPDK SW Engineer