From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id E1FCAB0A3
 for <dev@dpdk.org>; Wed, 18 Jun 2014 11:26:15 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 18 Jun 2014 02:21:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,499,1400050800"; d="scan'208";a="559456748"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by orsmga002.jf.intel.com with ESMTP; 18 Jun 2014 02:26:20 -0700
Received: from irsmsx101.ger.corp.intel.com ([169.254.1.245]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.105]) with mapi id 14.03.0123.003;
 Wed, 18 Jun 2014 10:25:45 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 1/9] eal: map shared config into exact same
 address as primary process
Thread-Index: AQHPikIN5i390jnUeU+Q0cbwxg6xvJt1bTiAgAEr3TA=
Date: Wed, 18 Jun 2014 09:25:45 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236976CC9CC29@IRSMSX101.ger.corp.intel.com>
References: <cover.1403018971.git.anatoly.burakov@intel.com>
 <fb3aaffcd381dcd174677d763d59cc80171faa90.1403018971.git.anatoly.burakov@intel.com>
 <2601191342CEEE43887BDE71AB9772580EFB7832@IRSMSX105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB7832@IRSMSX105.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/9] eal: map shared config into exact
	same	address as primary process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jun 2014 09:26:16 -0000

Hi Konstantin,

> I think we introduce a race window here.
> If secondary process would do first mmap() before rte_config.mem_config-
> >mem_cfg_addr was properly set by primary process, then it will try to do
> second mmap() with wrong address.
> I think we need to do second mmap() straight after
> rte_eal_mcfg_wait_complete(), or even just inside it.

Acknowledged, will respin.

Best regards,
Anatoly Burakov
DPDK SW Engineer