Re: [dpdk-dev] [PATCH] eal: Fixed EAL option --base-virtaddr

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, June 19, 2014 4:35 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] eal: Fixed EAL option --base-virtaddr
> 
> From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> When parsing EAL option --base-virtaddr
> errno was not being set to 0 before calling strtoull, therefore function might
> fail unnecesarily.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index 6994303..d204387 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -562,6 +562,7 @@ eal_parse_base_virtaddr(const char *arg)
>  	char *end;
>  	uint64_t addr;
> 
> +	errno = 0;
>  	addr = strtoull(arg, &end, 16);
> 
>  	/* check for errors */
> --
> 1.7.0.7

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Best regards,
Anatoly Burakov
DPDK SW Engineer