From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 862995947 for ; Wed, 5 Nov 2014 16:00:53 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 05 Nov 2014 07:08:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,320,1413270000"; d="scan'208";a="631961460" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 05 Nov 2014 07:10:14 -0800 Received: from irsmsx110.ger.corp.intel.com (163.33.3.25) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 5 Nov 2014 15:10:13 +0000 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.101]) by IRSMSX110.ger.corp.intel.com ([169.254.15.3]) with mapi id 14.03.0195.001; Wed, 5 Nov 2014 15:10:13 +0000 From: "Burakov, Anatoly" To: lxu , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: map uio resources after hugepages when the base_virtaddr is configured. Thread-Index: AQHP+PwmmmVWcq3WK0uPxBQDYbZnPZxSH3Pg Date: Wed, 5 Nov 2014 15:10:12 +0000 Message-ID: References: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> In-Reply-To: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: map uio resources after hugepages when the base_virtaddr is configured. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 15:00:54 -0000 I have a slight problems with this patch. The base_virtaddr doesn't necessarily correspond to an address that everyth= ing gets mapped to. It's a "hint" of sorts, that may or may not be taken in= to account by mmap. Therefore we can't simply assume that if we requested a= base-virtaddr, everything will get mapped at exactly that address. We also= can't assume that hugepages will be ordered one after the other and occupy= neatly all the contiguous virtual memory between base_virtaddr and base_vi= rtaddr + internal_config.memory - there may be holes, for whatever reasons. Also,=20 Thanks, Anatoly -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of lxu Sent: Wednesday, November 5, 2014 1:25 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] eal: map uio resources after hugepages when the= base_virtaddr is configured. --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/lin= uxapp/eal/eal_pci_uio.c index 7e62266..bc7ed3a 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c @@ -289,6 +289,11 @@ pci_uio_map_resource(struct rte_pci_device *dev) struct rte_pci_addr *loc =3D &dev->addr; struct mapped_pci_resource *uio_res; struct pci_map *maps; + static void * requested_addr =3D NULL; + if (internal_config.base_virtaddr && NULL =3D=3D requested_addr) { + requested_addr =3D (uint8_t *) internal_config.base_virtaddr=20 + + internal_config.memory; + } =20 dev->intr_handle.fd =3D -1; dev->intr_handle.type =3D RTE_INTR_HANDLE_UNKNOWN; @@ -371,10 +376,12 @@ = pci_uio_map_resource(struct rte_pci_device *dev) if (maps[j].addr !=3D NULL) fail =3D 1; else { - mapaddr =3D pci_map_resource(NULL, fd, (off_t)offset, + mapaddr =3D pci_map_resource(requested_addr, fd, (off_t)offset, (size_t)maps[j].size); if (mapaddr =3D=3D NULL) fail =3D 1; + else if (NULL !=3D requested_addr) + requested_addr =3D (uint8_t *)mapaddr + maps[j].size; } =20 if (fail) { -- 1.9.1