From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 254DF7F3C for ; Thu, 6 Nov 2014 15:19:56 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 06 Nov 2014 06:27:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,326,1413270000"; d="scan'208";a="627681271" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 06 Nov 2014 06:27:37 -0800 Received: from irsmsx108.ger.corp.intel.com (163.33.3.3) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 14:27:15 +0000 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.101]) by IRSMSX108.ger.corp.intel.com ([169.254.11.82]) with mapi id 14.03.0195.001; Thu, 6 Nov 2014 14:27:15 +0000 From: "Burakov, Anatoly" To: lxu , "dev@dpdk.org" Thread-Topic: [PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured. Thread-Index: AQHP+cvcd7iyHF+6JUu8+yoaz1Gz+5xTpX/w Date: Thu, 6 Nov 2014 14:27:14 +0000 Message-ID: References: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> <1415283104-29970-1-git-send-email-liang.xu@cinfotech.cn> In-Reply-To: <1415283104-29970-1-git-send-email-liang.xu@cinfotech.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] eal: map uio resources after hugepages when the base_virtaddr is configured. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 14:19:57 -0000 Few nitpicks. Static variables are always initialized to 0, so "=3D NULL" isn't necessary= , a declaration will suffice. Also, we have a macro RTE_PTR_ADD to add numb= ers to pointers, I think it would be better to use those. Otherwise, looks = fine to me. I still feel uneasy about depending on nothing being mapped directly after = hugepages (perhaps we could do mmap(bar_size) before trying pci_map_resourc= e, and increment requested_addr until we find a free spot?), but I imagine = this case would be quite rare, so probably it's not worth the added kludge. Thanks, Anatoly -----Original Message----- From: lxu [mailto:liang.xu@cinfotech.cn]=20 Sent: Thursday, November 6, 2014 2:12 PM To: dev@dpdk.org Cc: Burakov, Anatoly Subject: [PATCH v2] eal: map uio resources after hugepages when the base_vi= rtaddr is configured. --- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 29 +++++++++++++++++++++++++++= +- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/lin= uxapp/eal/eal_pci_uio.c index 7e62266..a591da3 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c @@ -273,6 +273,24 @@ pci_get_uio_dev(struct rte_pci_device *dev, char *dstb= uf, return uio_num; } =20 +static inline const struct rte_memseg * +get_physmem_last(void) +{ + const struct rte_memseg * seg =3D rte_eal_get_physmem_layout(); + const struct rte_memseg * last =3D seg; + unsigned i =3D 0; + + for (i=3D0; iaddr =3D=3D NULL) + break; + + if(seg->addr > last->addr) + last =3D seg; + + } + return last; +} + /* map the PCI resource of a PCI device in virtual memory */ int pci_uio_map_resource(struct rte_pci_device *dev) @@ -290,6 +308,13 @@ pci_uio_map_resource(struct rte_pci_device *dev) struct mapped_pci_resource *uio_res; struct pci_map *maps; =20 + /* map uio resource into user required virtual address */ + static void * requested_addr =3D NULL; + if (internal_config.base_virtaddr && NULL =3D=3D requested_addr) { + const struct rte_memseg * last =3D get_physmem_last(); + requested_addr =3D (void *)(last->addr_64 + last->len); + } + dev->intr_handle.fd =3D -1; dev->intr_handle.type =3D RTE_INTR_HANDLE_UNKNOWN; =20 @@ -371,10 +396,12 @@ pci_uio_map_resource(struct rte_pci_device *dev) if (maps[j].addr !=3D NULL) fail =3D 1; else { - mapaddr =3D pci_map_resource(NULL, fd, (off_t)offset, + mapaddr =3D pci_map_resource(requested_addr, fd, (off_t)offset, (size_t)maps[j].size); if (mapaddr =3D=3D NULL) fail =3D 1; + else if (NULL !=3D requested_addr) + requested_addr =3D (uint8_t *)mapaddr + maps[j].size; } =20 if (fail) { --=20 1.9.1