From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AC7097FED for ; Mon, 24 Nov 2014 14:26:18 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 24 Nov 2014 05:37:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="420784566" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 24 Nov 2014 05:27:23 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.244]) by IRSMSX154.ger.corp.intel.com ([169.254.12.166]) with mapi id 14.03.0195.001; Mon, 24 Nov 2014 13:37:04 +0000 From: "Burakov, Anatoly" To: "Richardson, Bruce" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 07/10] eal: add core list input format Thread-Index: AQHQBp2c1sD94GmkkEiSs+axmHMeLZxtbj2AgAI4BoCAAB7/AIAAAosAgAABO2A= Date: Mon, 24 Nov 2014 13:37:03 +0000 Message-ID: References: <1416692622-28886-1-git-send-email-thomas.monjalon@6wind.com> <20141123013517.GA3982@localhost.localdomain> <20141124112819.GA11552@bricha3-MOBL3> <4662010.O9okd8Allt@xps13> <20141124132821.GA11116@bricha3-MOBL3> In-Reply-To: <20141124132821.GA11116@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 07/10] eal: add core list input format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2014 13:26:19 -0000 > > > > Do you want to burn an option letter on that? It seems like it > > > > might be better to search the string for 0x and base the selection > > > > of bitmap of list parsing based on its presence or absence. > > > > It was the initial proposal (in April): > > http://dpdk.org/ml/archives/dev/2014-April/002173.html > > And I liked keeping only 1 option; > > http://dpdk.org/ml/archives/dev/2014-May/002722.html > > But Anatoly raised the compatibility problem: > > http://dpdk.org/ml/archives/dev/2014-May/002723.html > > Then there was no other comment so Didier and I reworked a separate > option. > > > > > The existing coremask parsing always assumes a hex coremask, so just > > > looking for a 0x will not work. I prefer this scheme of using a new > > > flag for this method of specifying the cores to use. > > > > > > If you don't want to use up a single-letter option, two alternatives: > > > 1) use a long option instead. > > > 2) if the -c parameter includes a "-" or a ",", treat it as a > > > new-style option, otherwise treat as old. The only abiguity here > > > would be for specifying a single core value 1-9 e.g. is "-c 6" a mask= with > two bits, or a single-core to run on. > > > [0 is obviously a named core as it's an invalid mask, and A-F are > > > obviously masks.] If we did want this scheme, I would suggest that > > > we allow trailing commas in the list specifier, so we can force > > > users to clear ambiguity by either writing "0x6" or "6," i.e. disallo= w > ambiguous values to avoid problems. > > > However, this is probably more work that it's worth to avoid using > > > up a letter option. > > > > > > I'd prefer any of these options to breaking backward compatibility in= this > case. > > > > We need a consensus here. > > Who is supporting a "burn" of an one-letter option with clear usage? > > Who is supporting a "re-merge" of the 2 syntaxes with more complicated > > rules (list syntax is triggered by presence of "-" or ",")? > > >=20 > Burn! I would still prefer a long option (we already have a coremask parameter, s= o another one is kind-of non-essential and IMO shouldn't belong in a scarce= resource of one-letter parameters), but if everyone else agrees, the "burn= " option is much more preferable to me than complicating syntax of an alrea= dy existing parameter. Thanks, Anatoly