From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 37B5F3F9 for ; Mon, 8 Dec 2014 13:21:04 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 08 Dec 2014 04:19:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,538,1413270000"; d="scan'208";a="644192077" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 08 Dec 2014 04:19:01 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.244]) by IRSMSX110.ger.corp.intel.com ([169.254.15.55]) with mapi id 14.03.0195.001; Mon, 8 Dec 2014 12:19:00 +0000 From: "Burakov, Anatoly" To: "Qiu, Michael" , "dev@dpdk.org" Thread-Topic: [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded Thread-Index: AQHQEtQWTzDcYsLiRESYI0m2Gq4lw5yFmfQA Date: Mon, 8 Dec 2014 12:19:00 +0000 Message-ID: References: <1417687227-21854-1-git-send-email-michael.qiu@intel.com> <1418035455-9434-1-git-send-email-michael.qiu@intel.com> In-Reply-To: <1418035455-9434-1-git-send-email-michael.qiu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] VFIO: Avoid to enable vfio while the module not loaded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2014 12:21:05 -0000 > When vfio module is not loaded when kernel support vfio feature, the > routine still try to open the container to get file description. >=20 > This action is not safe, and of cause got error messages: >=20 > EAL: Detected 40 lcore(s) > EAL: unsupported IOMMU type! > EAL: VFIO support could not be initialized > EAL: Setting up memory... >=20 > This may make user confuse, this patch make it reasonable and much more > soomth to user. >=20 > Signed-off-by: Michael Qiu > --- > v4 --> v3: > 1. Remove RTE_LOG for params check > 2. Remove "vfio" module check as "vfio_iommu_type1" > loaded indecated "vfio" loaded >=20 > v3 --> v2: > 1. Add error log in rte_eal_check_module() > 2. Some code clean up. >=20 > v2 --> v1: > 1. Move check_module() from rte_common.h to eal_private.h > and rename to rte_eal_check_module(). > To make it linuxapp only. > 2. Some code clean up. >=20 > lib/librte_eal/common/eal_private.h | 42 > ++++++++++++++++++++++++++++++ > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 29 ++++++++++++++++++--- > 2 files changed, 68 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/librte_eal/common/eal_private.h > b/lib/librte_eal/common/eal_private.h > index 232fcec..e877a25 100644 > --- a/lib/librte_eal/common/eal_private.h > +++ b/lib/librte_eal/common/eal_private.h > @@ -35,6 +35,9 @@ > #define _EAL_PRIVATE_H_ >=20 > #include > +#include > +#include > +#include >=20 > /** > * Initialize the memzone subsystem (private to eal). > @@ -203,4 +206,43 @@ int rte_eal_alarm_init(void); > */ > int rte_eal_dev_init(void); >=20 > +/** > + * Function is to check if the kernel module(like, vfio, > +vfio_iommu_type1, > + * etc.) loaded. > + * > + * @param module_name > + * The module's name which need to be checked > + * > + * @return > + * -1 means some error happens(NULL pointer or open failure) > + * 0 means the module not loaded > + * 1 means the module loaded > + */ > +static inline int > +rte_eal_check_module(const char *module_name) { > + char mod_name[30]; /* Any module names can be longer than 30 > bytes? */ > + int ret =3D 0; > + > + if (NULL =3D=3D module_name) > + return -1; > + > + FILE * fd =3D fopen("/proc/modules", "r"); > + if (NULL =3D=3D fd) { > + RTE_LOG(ERR, EAL, "Open /proc/modules failed!" > + " error %i (%s)\n", errno, strerror(errno)); > + return -1; > + } > + while(!feof(fd)) { > + fscanf(fd, "%s %*[^\n]", mod_name); > + if(!strcmp(mod_name, module_name)) { > + ret =3D 1; > + break; > + } > + } > + fclose(fd); > + > + return ret; > +} > + Apologies for not bringing this up before, but do we really want the rte_ea= l_check_module inline in the header? I think it would be better to declare = it in eal_private but move the definition into eal.c. > #endif /* _EAL_PRIVATE_H_ */ > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > index c1246e8..8c54d2a 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include >=20 > #include "eal_filesystem.h" > #include "eal_pci_init.h" > @@ -339,10 +340,15 @@ pci_vfio_get_container_fd(void) > ret =3D ioctl(vfio_container_fd, VFIO_CHECK_EXTENSION, > VFIO_TYPE1_IOMMU); > if (ret !=3D 1) { > if (ret < 0) > - RTE_LOG(ERR, EAL, " could not get IOMMU > type, " > - "error %i (%s)\n", errno, > strerror(errno)); > + RTE_LOG(ERR, EAL, " could not get IOMMU > type," > + " error %i (%s)\n", errno, > + strerror(errno)); > else > - RTE_LOG(ERR, EAL, " unsupported IOMMU > type!\n"); > + /* Better to show the IOMMU type return > from > + * kernel for easy debug > + */ > + RTE_LOG(ERR, EAL, " unsupported IOMMU > type" > + " detected: %d in VFIO\n", ret); I'm not sure this message is meaningful. That ioctl call can either -1, 0 o= r 1. We already handle 1 separately; -1 means an error; 0 means IOMMU type = 1 is not supported. The return value will *not* indicate which IOMMU types = *are* currently supported - it will only indicate that the IOMMU type you r= equested is not supported. So there's really no point in indicating the ret= urn value in case of ret 0 - it is best to just mention that requested IOMM= U type support is not enabled in VFIO. > close(vfio_container_fd); > return -1; > } > @@ -783,11 +789,28 @@ pci_vfio_enable(void) { > /* initialize group list */ > int i; > + int module_vfio_type1; >=20 > for (i =3D 0; i < VFIO_MAX_GROUPS; i++) { > vfio_cfg.vfio_groups[i].fd =3D -1; > vfio_cfg.vfio_groups[i].group_no =3D -1; > } > + > + module_vfio_type1 =3D rte_eal_check_module("vfio_iommu_type1"); > + > + /* return error directly */ > + if (module_vfio_type1 =3D=3D -1) { > + RTE_LOG(INFO, EAL, "Could not get loaded module > details!\n"); > + return -1; > + } > + > + /* return 0 if VFIO modules not loaded */ > + if (module_vfio_type1 =3D=3D 0) { > + RTE_LOG(INFO, EAL, "VFIO modules not all loaded," > + " skip VFIO support ...\n"); > + return 0; > + } > + > vfio_cfg.vfio_container_fd =3D pci_vfio_get_container_fd(); >=20 > /* check if we have VFIO driver enabled */ > -- > 1.9.3