From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 65C068031 for ; Tue, 16 Dec 2014 11:36:38 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 16 Dec 2014 02:36:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,586,1413270000"; d="scan'208";a="648375245" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga002.fm.intel.com with ESMTP; 16 Dec 2014 02:36:34 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.244]) by IRSMSX105.ger.corp.intel.com ([163.33.3.28]) with mapi id 14.03.0195.001; Tue, 16 Dec 2014 10:36:34 +0000 From: "Burakov, Anatoly" To: "Sujith Sankar (ssujith)" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT Thread-Index: AQHQFeR5DfuNivKUskqdsN9BaeWDHpyRULeAgABQkYCAAGbVUIAAA7wAgAAASAA= Date: Tue, 16 Dec 2014 10:36:33 +0000 Message-ID: References: <1418372303-31565-1-git-send-email-ssujith@cisco.com> <5911790.4rCTPaIceN@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 10:36:38 -0000 > -----Original Message----- > From: Sujith Sankar (ssujith) [mailto:ssujith@cisco.com] > Sent: Tuesday, December 16, 2014 10:34 AM > To: Burakov, Anatoly; Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT >=20 >=20 >=20 > On 16/12/14 3:52 pm, "Burakov, Anatoly" > wrote: >=20 > >> On 16/12/14 4:54 am, "Thomas Monjalon" > > >> wrote: > >> > >> >2014-12-12 13:48, Sujith Sankar: > >> >> This patch corrects the usage of the flag VFIO_PRESENT in enic > >>driver. > >> > > >> >Please, could you explain why the flag VFIO_PRESENT was not well > used? > >> > >> Without including eal_vfio.h, VFIO_PRESENT is not available in enic. > >> Hence VFIO specific code in enic was not getting compiled and some > >>errors were generated during run-time. > >> > >> > > >> >> This has uncovered a few warnings, and this patch corrects those to= o. > >> >[...] > >> >> --- a/lib/librte_pmd_enic/enic_main.c > >> >> +++ b/lib/librte_pmd_enic/enic_main.c > >> >> @@ -39,6 +39,7 @@ > >> >> #include > >> >> #include > >> >> #include > >> >> +#include > >> >> > >> >> #include > >> >> #include > >> >> @@ -46,6 +47,7 @@ > >> >> #include > >> >> #include > >> >> #include > >> >> +#include > >> > > >> >This header was not designed to be included by PMDs. > >> >It will break compilation on BSD. > >> > >> Is there an alternative to make VFIO_PRESENT available in enic? > >> Please advise. > >> > >> Thanks, > >> -Sujith > >> > >> > > >> >> #include "enic_compat.h" > >> >> #include "enic.h" > >> >> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct > >> >>rte_pci_device *hwdev, > >> >> /* Nothing to be done */ > >> >> } > >> >> > >> >> +#ifndef VFIO_PRESENT > >> >> static void > >> >> enic_intr_handler(__rte_unused struct rte_intr_handle *handle, > >> >> void *arg) > >> >> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct > >> >>rte_intr_handle *handle, > >> >> > >> >> enic_log_q_error(enic); > >> >> } > >> >> +#endif > >> > > >> >-- > >> >Thomas > > > >Hi Sujith > > > >Thomas is correct, VFIO code is designed to be EAL-only (mainly because > >it's Linuxapp-specific, and PMD's are intended to be cross-platform at > >least when it comes to compilation). Whatever it is that you're working > >around is better fixed in the EAL itself rather than in the PMD. >=20 > I agree with you and Thomas. Let me find the root cause for the false tr= igger. >=20 > Thanks, > -Sujith >=20 You may find it in EAL VFIO interrupts code. When VFIO enables some interru= pt types, it manually sends a trigger. Normally, this "trigger" just enable= s interrupts, but maybe for ENIC it's different. I therefore suggest you to= look there first. Thanks, Anatoly