From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 659C45A35
 for <dev@dpdk.org>; Thu, 15 Jan 2015 14:43:20 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 15 Jan 2015 05:40:33 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,403,1418112000"; d="scan'208";a="637734801"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by orsmga001.jf.intel.com with ESMTP; 15 Jan 2015 05:43:17 -0800
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.11]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.222]) with mapi id 14.03.0195.001;
 Thu, 15 Jan 2015 13:42:17 +0000
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Qiu, Michael"
 <michael.qiu@intel.com>
Thread-Topic: [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded
Thread-Index: AQHQFG78yZzDmFNlgEmnV3x7yWaB5ZyItYSQgDiys4CAAABDAA==
Date: Thu, 15 Jan 2015 13:42:15 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E4512369780C3CDC1@IRSMSX109.ger.corp.intel.com>
References: <1418035455-9434-1-git-send-email-michael.qiu@intel.com>
 <1418211977-8218-1-git-send-email-michael.qiu@intel.com>
 <C6ECDF3AB251BE4894318F4E4512369780C24883@IRSMSX109.ger.corp.intel.com>
 <1613897.2bqBHJQoa5@xps13>
In-Reply-To: <1613897.2bqBHJQoa5@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6] VFIO: Avoid to enable vfio while the
 module not loaded
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2015 13:43:21 -0000

Yep, apologies, it's my fault as it was my suggestion. I knew there was a l=
inuxapp-only EAL header, for some reason I thought it's eal_private. Any su=
ggestions on where to put this function? I don't think BSD needs this funct=
ion.=20

Thanks,
Anatoly

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, January 15, 2015 1:38 PM
> To: Qiu, Michael
> Cc: Burakov, Anatoly; dev@dpdk.org; Xie, Huawei
> Subject: Re: [PATCH v6] VFIO: Avoid to enable vfio while the module not
> loaded
>=20
> > > When vfio module is not loaded when kernel support vfio feature, the
> > > routine still try to open the container to get file description.
> > >
> > > This action is not safe, and of cause got error messages:
> > >
> > > EAL: Detected 40 lcore(s)
> > > EAL:   unsupported IOMMU type!
> > > EAL: VFIO support could not be initialized
> > > EAL: Setting up memory...
> > >
> > > This may make user confuse, this patch make it reasonable and much
> > > more soomth to user.
> > >
> > > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> >
> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>=20
> Note that rte_eal_check_module has no bsd counterpart.
> It could be needed later.
>=20
> Applied
>=20
> Thanks
> --
> Thomas