From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id C4C6D683D
 for <dev@dpdk.org>; Tue, 31 Mar 2015 11:05:06 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 31 Mar 2015 02:05:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,499,1422950400"; d="scan'208";a="474821800"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2015 02:05:05 -0700
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.95]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.129]) with mapi id 14.03.0224.002;
 Tue, 31 Mar 2015 10:05:04 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: VFIO in setup.sh
Thread-Index: AQHQaykI45dk4gV0qkmSXOax/VBvYZ01a6cAgADhR1A=
Date: Tue, 31 Mar 2015 09:05:04 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E4512369780C7A59F@IRSMSX109.ger.corp.intel.com>
References: <20150330133507.77ff6b1d@urahara> <20150330133742.57adef52@urahara>
In-Reply-To: <20150330133742.57adef52@urahara>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] VFIO in setup.sh
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2015 09:05:07 -0000

> > 3. Why depend on location of vfio module in kernel tree?
> >    modprobe does the right thing and finds it.
> >
> > 	VFIO_PATH=3D"kernel/drivers/vfio/pci/vfio-pci.ko"
> >
> > 	echo "Loading VFIO module"
> > 	/sbin/lsmod | grep -s vfio_pci > /dev/null
> > 	if [ $? -ne 0 ] ; then
> > 		if [ -f /lib/modules/$(uname -r)/$VFIO_PATH ] ; then
> > 			sudo /sbin/modprobe vfio-pci
> > 		fi
> > 	fi
> >

Here I agree. Needs to be fixed.

Thanks,
Anatoly