DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vfio: don't silently drop VFIO support
Date: Tue, 21 Apr 2015 09:34:27 +0000	[thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E4512369780C828EF@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1429554771-32365-1-git-send-email-stephen@networkplumber.org>

Hi Stephen,

> The VFIO_PRESENT #define was a landmine and we hit it.
> The DPDK has a config system and it should be used rather than silently
> dropping a feature during build only to have it fail at run time.
> 
> If VFIO is configured, and the kernel headers are not present the build
> should fail. Rather than leaving developers puzzling why the build system
> (with old kernel headers) produced non functioning DPDK and their system
> (with new kernel headers) produced correctly working DPDK.
> 
> As a matter of policy, really no code should be looking at <linux/version.h>
> except for kernel drivers with compat files.

In theory, I agree with you. In practice however, this change will unconditionally break builds on pre-VFIO kernels (<3.6). This may be OK now, but wasn't OK at the time it was developed because pre-VFIO kernels were still very much prevalent. AFAIK, VFIO is enabled by default, so maybe we should disable it in the default configs?

Thanks,
Anatoly

  reply	other threads:[~2015-04-21  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 18:32 Stephen Hemminger
2015-04-21  9:34 ` Burakov, Anatoly [this message]
2015-04-21 17:34   ` Stephen Hemminger
2015-04-22  8:59     ` Burakov, Anatoly
2015-04-22 19:01       ` Stephen Hemminger
2015-04-23  8:51         ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6ECDF3AB251BE4894318F4E4512369780C828EF@IRSMSX109.ger.corp.intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).