DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vfio: don't silently drop VFIO support
Date: Thu, 23 Apr 2015 08:51:11 +0000	[thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E4512369780C92B79@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <20150422120133.44b27408@urahara>

Hi Stephen,

> What we ended up doing is a second patch to have a "compat_vfio.h" file to
> allow building on older systems. I will send that as a follow on.

I would argue it should be part of this series, as without them the patch breaks compilation on older kernels.

> The problem is compounded by the fact that VFIO or not has to be decided
> by startup scripts prior to starting the DPDK application. The startup scripts
> have no way of knowing that the DPDK application was built with broken
> VFIO support. That is why I think the original method with VFIO_PRESENT
> was not the correct way to handle this.

That makes sense, so no more objections from me :-)

Thanks,
Anatoly

      reply	other threads:[~2015-04-23  8:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 18:32 Stephen Hemminger
2015-04-21  9:34 ` Burakov, Anatoly
2015-04-21 17:34   ` Stephen Hemminger
2015-04-22  8:59     ` Burakov, Anatoly
2015-04-22 19:01       ` Stephen Hemminger
2015-04-23  8:51         ` Burakov, Anatoly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6ECDF3AB251BE4894318F4E4512369780C92B79@IRSMSX109.ger.corp.intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).