From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 2C3675A71
 for <dev@dpdk.org>; Thu, 23 Apr 2015 10:51:15 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 23 Apr 2015 01:51:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,629,1422950400"; d="scan'208";a="684419518"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by orsmga001.jf.intel.com with ESMTP; 23 Apr 2015 01:51:13 -0700
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.201]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.76]) with mapi id 14.03.0224.002;
 Thu, 23 Apr 2015 09:51:12 +0100
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [dpdk-dev] [PATCH] vfio: don't silently drop VFIO support
Thread-Index: AQHQe5iKlnF3SJ8U8Uu+6UqyJsRwB51XNKrwgAB2XICAARD/gIAAmYWAgAD4FNA=
Date: Thu, 23 Apr 2015 08:51:11 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E4512369780C92B79@IRSMSX109.ger.corp.intel.com>
References: <1429554771-32365-1-git-send-email-stephen@networkplumber.org>
 <C6ECDF3AB251BE4894318F4E4512369780C828EF@IRSMSX109.ger.corp.intel.com>
 <20150421103459.6b8094d0@urahara>
 <C6ECDF3AB251BE4894318F4E4512369780C908FF@IRSMSX109.ger.corp.intel.com>
 <20150422120133.44b27408@urahara>
In-Reply-To: <20150422120133.44b27408@urahara>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vfio: don't silently drop VFIO support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Apr 2015 08:51:15 -0000

Hi Stephen,

> What we ended up doing is a second patch to have a "compat_vfio.h" file t=
o
> allow building on older systems. I will send that as a follow on.

I would argue it should be part of this series, as without them the patch b=
reaks compilation on older kernels.

> The problem is compounded by the fact that VFIO or not has to be decided
> by startup scripts prior to starting the DPDK application. The startup sc=
ripts
> have no way of knowing that the DPDK application was built with broken
> VFIO support. That is why I think the original method with VFIO_PRESENT
> was not the correct way to handle this.

That makes sense, so no more objections from me :-)

Thanks,
Anatoly