From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Harpal Singh <harpal.sd@samsung.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] vfio: Added hot removal feature for vfio
Date: Tue, 4 Aug 2015 14:24:09 +0000 [thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E4512369780CEF100@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1438688332-3392-2-git-send-email-harpal.sd@samsung.com>
Hi Harpal,
> This patch will add a new API i.e. pci_vfio_unmap_resource.
> It will basically cleanup all the vfio resources allocated for a device.
> cleanup includes :-
> 1) removing vfio_res from vfio_res_list
> 2) unmap mapped bars
> 3) close device fd
> 4) close group fd
> 5) free vfio_res
Do I understand it correctly that your code assumes that there is always a single PCI device per group? From what I understand, unless we're only using a single port from the NIC, this won't be the case.
Also, extraneous comment symbols:
> + // /* unmap BARs */
Best regards,
Anatoly
next prev parent reply other threads:[~2015-08-04 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 11:38 [dpdk-dev] [PATCH 0/3] vfio hotplug feature Harpal Singh
2015-08-04 11:38 ` [dpdk-dev] [PATCH 1/3] vfio: Added hot removal feature for vfio Harpal Singh
2015-08-04 14:24 ` Burakov, Anatoly [this message]
2015-08-04 11:38 ` [dpdk-dev] [PATCH 2/3] vfio: Added vfio req interrupt support Harpal Singh
2015-08-04 11:38 ` [dpdk-dev] [PATCH 3/3] vfio: Added hotplug test program Harpal Singh
[not found] <6F.6F.25195.454C4C55@epcpsbgx4.samsung.com>
2015-08-07 15:23 ` [dpdk-dev] [PATCH 1/3] vfio: Added hot removal feature for vfio Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6ECDF3AB251BE4894318F4E4512369780CEF100@IRSMSX109.ger.corp.intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=harpal.sd@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).