From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DCDBC6A94 for ; Tue, 4 Aug 2015 16:24:12 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 04 Aug 2015 07:24:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,609,1432623600"; d="scan'208";a="776553960" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 04 Aug 2015 07:24:10 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.130]) by IRSMSX104.ger.corp.intel.com ([169.254.5.131]) with mapi id 14.03.0224.002; Tue, 4 Aug 2015 15:24:10 +0100 From: "Burakov, Anatoly" To: Harpal Singh , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/3] vfio: Added hot removal feature for vfio Thread-Index: AQHQzq6cz9j1LRZfxEKzuYhW5JOnF5375B+A Date: Tue, 4 Aug 2015 14:24:09 +0000 Message-ID: References: <1438688332-3392-1-git-send-email-harpal.sd@samsung.com> <1438688332-3392-2-git-send-email-harpal.sd@samsung.com> In-Reply-To: <1438688332-3392-2-git-send-email-harpal.sd@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] vfio: Added hot removal feature for vfio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 14:24:13 -0000 Hi Harpal, > This patch will add a new API i.e. pci_vfio_unmap_resource. > It will basically cleanup all the vfio resources allocated for a device. > cleanup includes :- > 1) removing vfio_res from vfio_res_list > 2) unmap mapped bars > 3) close device fd > 4) close group fd > 5) free vfio_res Do I understand it correctly that your code assumes that there is always a = single PCI device per group? From what I understand, unless we're only usin= g a single port from the NIC, this won't be the case.=20 Also, extraneous comment symbols: > + // /* unmap BARs */ Best regards, Anatoly