From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id AEE49952
 for <dev@dpdk.org>; Thu, 14 Jan 2016 10:50:18 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 14 Jan 2016 01:50:19 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,293,1449561600"; d="scan'208";a="892997452"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2016 01:50:17 -0800
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 14 Jan 2016 09:50:15 +0000
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.56]) by
 IRSMSX156.ger.corp.intel.com ([169.254.3.193]) with mapi id 14.03.0248.002;
 Thu, 14 Jan 2016 09:50:16 +0000
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [PATCH v2] vfio: Support for no-IOMMU mode
Thread-Index: AQHRTiHTPIMRX2WYXki4bOMotCi+hZ76xWsA
Date: Thu, 14 Jan 2016 09:50:15 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E45123697820BD5A8@IRSMSX109.ger.corp.intel.com>
References: <1450728967-9686-1-git-send-email-anatoly.burakov@intel.com>
 <1452688569-14695-1-git-send-email-anatoly.burakov@intel.com>
 <20160113084531.6bd4e3c6@xeon-e3>
In-Reply-To: <20160113084531.6bd4e3c6@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 09:50:19 -0000

Hi Stephen,

> > +/* IOMMU types we support */
> > +static const struct vfio_iommu_type iommu_types[] =3D {
> > +		/* x86 IOMMU, otherwise known as type 1 */
> > +		{ VFIO_TYPE1_IOMMU, "Type 1",
> &vfio_iommu_type1_dma_map},
> > +		/* IOMMU-less mode */
> > +		{ VFIO_NOIOMMU_IOMMU, "No-IOMMU",
> &vfio_iommu_noiommu_dma_map},
> > +};
> > +
>=20
> Nit.. Why full-tab indent here?

Readability mainly... at least it's more readable to me that way. I can cha=
nge that if necessary.

Thanks,
Anatoly