From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6309C9434 for ; Wed, 27 Jan 2016 11:08:35 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 27 Jan 2016 02:08:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,354,1449561600"; d="scan'208";a="36969843" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga004.fm.intel.com with ESMTP; 27 Jan 2016 02:08:33 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.100]) by IRSMSX108.ger.corp.intel.com ([169.254.11.102]) with mapi id 14.03.0248.002; Wed, 27 Jan 2016 10:08:14 +0000 From: "Burakov, Anatoly" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode Thread-Index: AQHRTf8OF9iAnvlqTUKNAwE6rQlKEZ8PJ6AAgAAQx4A= Date: Wed, 27 Jan 2016 10:08:13 +0000 Message-ID: References: <1450728967-9686-1-git-send-email-anatoly.burakov@intel.com> <1452688569-14695-1-git-send-email-anatoly.burakov@intel.com> <1584319.QMRQbZMs1h@xps13> In-Reply-To: <1584319.QMRQbZMs1h@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 10:08:35 -0000 Hi Thomas, > The comments "function pointer typedef" or "structure to hold" don't > bring new information. Please keep it short. I'll fix that and submit a v3, thanks. > Why a new file for these functions? Well, my thought was to make future extensions easier by way of avoiding mi= xing irrelevant and/or general code with driver-specific code. I can change= it back if that's not OK. Thanks, Anatoly