From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id AAC2AC492
 for <dev@dpdk.org>; Thu, 28 Jan 2016 15:16:56 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 28 Jan 2016 06:16:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,358,1449561600"; d="scan'208";a="870767554"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by orsmga001.jf.intel.com with ESMTP; 28 Jan 2016 06:16:54 -0800
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 28 Jan 2016 14:16:51 +0000
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.100]) by
 IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0248.002;
 Thu, 28 Jan 2016 14:16:52 +0000
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v6] vfio: Support for no-IOMMU mode
Thread-Index: AQHRWcM07051w28Q5UmitVgfAa52G58Q9IoAgAAEOfA=
Date: Thu, 28 Jan 2016 14:16:50 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E45123697820C5479@IRSMSX109.ger.corp.intel.com>
References: <1453913438-22991-1-git-send-email-anatoly.burakov@intel.com>
 <1453982274-16717-1-git-send-email-anatoly.burakov@intel.com>
 <26948068.xeVA9KiJZ0@xps13>
In-Reply-To: <26948068.xeVA9KiJZ0@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6] vfio: Support for no-IOMMU mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2016 14:16:57 -0000

Hi Thomas,

> 2016-01-28 11:57, Anatoly Burakov:
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 5, 0)
>=20
> Why not #ifndef VFIO_NOIOMMU_IOMMU?
> It would avoid some backport issue.

I don't see how it could. Versions post-4.5 will have VFIO_NOIOMMU_IOMMU, s=
o no issue there. Pre-4.5 versions, whether they do or do not have VFIO_NOI=
OMMU_IOMMU defined, will have RTE_VFIO_NOIOMMU defined as 8 regardless.

Thanks,
Anatoly