DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
	"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
	"david.marchand@6wind.com" <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal:Change log output to DEBUG instead of INFO
Date: Thu, 18 Feb 2016 10:18:56 +0000	[thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E45123697820C85AF@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1928276.P2Lqin6BEp@xps13>

Hi

Apologies for late reply, was away. Can't comment on other lines, but

> > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > index 0e6c48a..e0c13de 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> >
> >  	/* return 0 if VFIO modules not loaded */
> >  	if (module_vfio_type1 == 0) {
> > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> >  			"skip VFIO support...\n");
> >  		return 0;
> >  	}
> >
> 

Should people be forced to recompile DPDK with debug logs (and get all this
additional debug output) just to see why VFIO doesn't get initialized? I would
argue this message is not as serious an annoyance to warrant this change, but
maybe Keith has a different opinion.

Either way, I don't feel strongly for or against the change.

Thanks,
Anatoly

  reply	other threads:[~2016-02-18 10:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 19:40 Keith Wiles
2016-02-12 17:56 ` Thomas Monjalon
2016-02-18 10:18   ` Burakov, Anatoly [this message]
2016-02-18 14:08     ` Thomas Monjalon
2016-02-18 14:38       ` Burakov, Anatoly
2016-03-13 22:36 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6ECDF3AB251BE4894318F4E45123697820C85AF@IRSMSX109.ger.corp.intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).