From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 96E002C06 for <dev@dpdk.org>; Mon, 4 Jul 2016 12:22:20 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 04 Jul 2016 03:22:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,574,1459839600"; d="scan'208";a="1000413539" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 04 Jul 2016 03:22:10 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.193]) by IRSMSX153.ger.corp.intel.com ([169.254.9.105]) with mapi id 14.03.0248.002; Mon, 4 Jul 2016 11:22:09 +0100 From: "Burakov, Anatoly" <anatoly.burakov@intel.com> To: Jan Viktorin <viktorin@rehivetech.com>, "dev@dpdk.org" <dev@dpdk.org> CC: David Marchand <david.marchand@6wind.com>, "Wiles, Keith" <keith.wiles@intel.com>, Santosh Shukla <sshukla@mvista.com>, "Stephen Hemminger" <stephen@networkplumber.org>, Shreyansh Jain <shreyansh.jain@nxp.com> Thread-Topic: [PATCH v2 01/16] vfio: fix include of eal_private.h to be local Thread-Index: AQHRxXSUDBBlYTMmu0aSN8DkMfsE4KAIMGwg Date: Mon, 4 Jul 2016 10:22:08 +0000 Message-ID: <C6ECDF3AB251BE4894318F4E45123697821306F6@IRSMSX109.ger.corp.intel.com> References: <1461937456-22943-1-git-send-email-viktorin@rehivetech.com> <1465822926-23742-2-git-send-email-viktorin@rehivetech.com> In-Reply-To: <1465822926-23742-2-git-send-email-viktorin@rehivetech.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzc5NWUyZGYtMjkzMy00MWEzLWI4M2ItMzEzY2M3MzU5NWVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImwwQ2JwZFVUOWJRUEF0aXJIS1l2RDNJSFZ0amxjN3M4UXdnSVlZRmZEZ2M9In0= x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 01/16] vfio: fix include of eal_private.h to be local X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 04 Jul 2016 10:22:21 -0000 > -----Original Message----- > From: Jan Viktorin [mailto:viktorin@rehivetech.com] > Sent: Monday, June 13, 2016 2:02 PM > To: dev@dpdk.org > Cc: Jan Viktorin <viktorin@rehivetech.com>; Burakov, Anatoly > <anatoly.burakov@intel.com>; David Marchand > <david.marchand@6wind.com>; Wiles, Keith <keith.wiles@intel.com>; > Santosh Shukla <sshukla@mvista.com>; Stephen Hemminger > <stephen@networkplumber.org>; Shreyansh Jain > <shreyansh.jain@nxp.com> > Subject: [PATCH v2 01/16] vfio: fix include of eal_private.h to be local >=20 > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com> > --- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > index 10266f8..257162b 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > @@ -43,11 +43,11 @@ > #include <rte_pci.h> > #include <rte_eal_memconfig.h> > #include <rte_malloc.h> > -#include <eal_private.h> >=20 > #include "eal_filesystem.h" > #include "eal_pci_init.h" > #include "eal_vfio.h" > +#include "eal_private.h" >=20 > /** > * @file > -- > 2.8.0 There's no patch cover letter so I'll reply to the first patch. I've done s= ome cursory testing with a NIC, nothing seems to be broken and the code loo= ks OK to me. So, once this patchset is rebased on latest master (patches 9,= 14 and 15 no longer apply cleanly), ack from me. Thanks, Anatoly