From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "JPF@zurich.ibm.com" <JPF@zurich.ibm.com>,
Gowrishankar Muthukrishnan <gowrishankar.m@in.ibm.com>
Subject: Re: [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver pointer
Date: Mon, 24 Apr 2017 09:28:23 +0000 [thread overview]
Message-ID: <C6ECDF3AB251BE4894318F4E45123697822102EE@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <20170420072402.38106-3-aik@ozlabs.ru>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alexey
> Kardashevskiy
> Sent: Thursday, April 20, 2017 8:24 AM
> To: dev@dpdk.org
> Cc: Alexey Kardashevskiy <aik@ozlabs.ru>; JPF@zurich.ibm.com;
> Gowrishankar Muthukrishnan <gowrishankar.m@in.ibm.com>
> Subject: [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver
> pointer
>
> The existing code initializes a PCI driver pointer but not the common one.
> As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c
> crashed as dev->device->driver==NULL.
>
> This adds missing initialization.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
This and 3rd patch - could you please split them so that there are no unrelated patches in the patchset? I.e. a patchset for VFIO changes, a separate patch for PCI, and a patch for bnx2x driver, and then just make a note in the annotation that they are interdependent.
Thanks,
Anatoly
next prev parent reply other threads:[~2017-04-24 9:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 7:23 [dpdk-dev] [PATCH dpdk 0/5] ppc64/spapr: Attempt to use on POWER8 Alexey Kardashevskiy
2017-04-20 7:23 ` [dpdk-dev] [PATCH dpdk 1/5] vfio/ppc64/spapr: Use correct structures for add/remove windows Alexey Kardashevskiy
2017-04-20 7:23 ` [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver pointer Alexey Kardashevskiy
2017-04-24 9:28 ` Burakov, Anatoly [this message]
2017-04-20 7:24 ` [dpdk-dev] [PATCH dpdk 3/5] RFC: bnx2x: Update firmware versions Alexey Kardashevskiy
2017-04-20 7:24 ` [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set Alexey Kardashevskiy
2017-04-20 19:31 ` gowrishankar muthukrishnan
2017-04-21 8:54 ` Andrew Rybchenko
2017-04-26 7:50 ` Alexey Kardashevskiy
2017-04-26 8:27 ` Burakov, Anatoly
2017-04-26 8:45 ` Alejandro Lucero
2017-04-26 8:58 ` Burakov, Anatoly
2017-04-26 10:24 ` Alejandro Lucero
2017-04-20 7:24 ` [dpdk-dev] [PATCH dpdk 5/5] RFC: vfio/ppc64/spapr: Use correct bus addresses for DMA map Alexey Kardashevskiy
2017-04-20 9:04 ` Jonas Pfefferle1
2017-04-20 13:25 ` Alexey Kardashevskiy
2017-04-20 14:22 ` Alexey Kardashevskiy
2017-04-20 15:15 ` Jonas Pfefferle1
2017-04-20 22:01 ` Alexey Kardashevskiy
2017-04-20 19:16 ` gowrishankar muthukrishnan
2017-04-21 3:42 ` Alexey Kardashevskiy
2017-04-21 8:43 ` Alexey Kardashevskiy
[not found] ` <OF6F33ED54.7950E1EF-ONC1258109.003295E3-C1258109.00333E2E@notes.na.collabserv.com>
2017-04-22 0:12 ` Alexey Kardashevskiy
2017-04-24 9:40 ` Burakov, Anatoly
2017-04-21 8:51 ` gowrishankar muthukrishnan
[not found] ` <OF45247CC5.192F9D29-ONC1258109.002D6497-C1258109.002F2868@notes.na.collabserv.com>
2017-04-21 8:59 ` Alexey Kardashevskiy
2017-04-22 21:11 ` [dpdk-dev] [PATCH dpdk 0/5] ppc64/spapr: Attempt to use on POWER8 Olga Shern
2017-04-23 13:35 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6ECDF3AB251BE4894318F4E45123697822102EE@IRSMSX109.ger.corp.intel.com \
--to=anatoly.burakov@intel.com \
--cc=JPF@zurich.ibm.com \
--cc=aik@ozlabs.ru \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).