From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A5C45298F for ; Mon, 24 Apr 2017 11:28:27 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2017 02:28:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,244,1488873600"; d="scan'208";a="849141406" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 24 Apr 2017 02:28:24 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.12]) by IRSMSX103.ger.corp.intel.com ([169.254.3.241]) with mapi id 14.03.0319.002; Mon, 24 Apr 2017 10:28:24 +0100 From: "Burakov, Anatoly" To: Alexey Kardashevskiy , "dev@dpdk.org" CC: "JPF@zurich.ibm.com" , Gowrishankar Muthukrishnan Thread-Topic: [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver pointer Thread-Index: AQHSuadG48mGzOciFkizT2BZlBtZJKHURnKQ Date: Mon, 24 Apr 2017 09:28:23 +0000 Message-ID: References: <20170420072402.38106-1-aik@ozlabs.ru> <20170420072402.38106-3-aik@ozlabs.ru> In-Reply-To: <20170420072402.38106-3-aik@ozlabs.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_PUBLIC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTgwYWZhNzQtODNmYy00YmY4LWFlODktMDA5MDM4MDU3ODAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNi41LjkuMyIsIlRydXN0ZWRMYWJlbEhhc2giOiJCWDZpZUx3ZnNnQ3h5UFNLNG5kOTFYYlQ1Q2NSWE5ab0NBRHpDKzIxZlNjPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2017 09:28:28 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alexey > Kardashevskiy > Sent: Thursday, April 20, 2017 8:24 AM > To: dev@dpdk.org > Cc: Alexey Kardashevskiy ; JPF@zurich.ibm.com; > Gowrishankar Muthukrishnan > Subject: [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver > pointer >=20 > The existing code initializes a PCI driver pointer but not the common one= . > As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c > crashed as dev->device->driver=3D=3DNULL. >=20 > This adds missing initialization. >=20 > Signed-off-by: Alexey Kardashevskiy This and 3rd patch - could you please split them so that there are no unrel= ated patches in the patchset? I.e. a patchset for VFIO changes, a separate = patch for PCI, and a patch for bnx2x driver, and then just make a note in t= he annotation that they are interdependent. Thanks, Anatoly