From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 164B67CD2 for ; Mon, 4 Sep 2017 17:35:25 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 08:35:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="1214547729" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 04 Sep 2017 08:35:22 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.28]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 16:35:21 +0100 From: "Burakov, Anatoly" To: santosh , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "olivier.matz@6wind.com" , "maxime.coquelin@redhat.com" , "Gonzalez Monroy, Sergio" , "Richardson, Bruce" , "shreyansh.jain@nxp.com" , "gaetan.rivet@6wind.com" , "stephen@networkplumber.org" , "aconole@redhat.com" Thread-Topic: [PATCH v7 2/9] eal/pci: get iommu class Thread-Index: AQHTIglLvyp8iRdJ1k6mrZXwfC/toqKk1hvQ///1zgCAABEfYP//9AUAgAARHqA= Date: Mon, 4 Sep 2017 15:35:21 +0000 Message-ID: References: <20170814161059.6684-1-santosh.shukla@caviumnetworks.com> <20170831032618.7120-1-santosh.shukla@caviumnetworks.com> <20170831032618.7120-3-santosh.shukla@caviumnetworks.com> <1856034f-15c1-36e2-8b26-952a584bc982@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWZjODY5M2UtMGJkMC00NTdkLWFkZjMtMGNkMmE2MWNjODgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkplOTJNVDFHMlFob08wblZvUFBjNHJJRlNCYlpOM3E1UWdhSXNKc2laZzQ9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 2/9] eal/pci: get iommu class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 15:35:26 -0000 > From: santosh [mailto:santosh.shukla@caviumnetworks.com] > Sent: Monday, September 4, 2017 4:32 PM > To: Burakov, Anatoly ; dev@dpdk.org > Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; > hemant.agrawal@nxp.com; olivier.matz@6wind.com; > maxime.coquelin@redhat.com; Gonzalez Monroy, Sergio > ; Richardson, Bruce > ; shreyansh.jain@nxp.com; > gaetan.rivet@6wind.com; stephen@networkplumber.org; > aconole@redhat.com > Subject: Re: [PATCH v7 2/9] eal/pci: get iommu class >=20 > Hi Anatoly, >=20 >=20 > On Monday 04 September 2017 08:46 PM, Burakov, Anatoly wrote: > > Hi Santosh, > > > >> From: santosh [mailto:santosh.shukla@caviumnetworks.com] > >> Sent: Monday, September 4, 2017 4:14 PM > >> To: Burakov, Anatoly ; dev@dpdk.org > >> Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; > >> hemant.agrawal@nxp.com; olivier.matz@6wind.com; > >> maxime.coquelin@redhat.com; Gonzalez Monroy, Sergio > >> ; Richardson, Bruce > >> ; shreyansh.jain@nxp.com; > >> gaetan.rivet@6wind.com; stephen@networkplumber.org; > >> aconole@redhat.com > >> Subject: Re: [PATCH v7 2/9] eal/pci: get iommu class > >> > >> Hi Anatoly, > >> > >> > >> On Monday 04 September 2017 08:23 PM, Burakov, Anatoly wrote: > >>>> From: Santosh Shukla [mailto:santosh.shukla@caviumnetworks.com] > >>>> Sent: Thursday, August 31, 2017 4:26 AM > >>>> To: dev@dpdk.org > >>>> Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; > >>>> hemant.agrawal@nxp.com; olivier.matz@6wind.com; > >>>> maxime.coquelin@redhat.com; Gonzalez Monroy, Sergio > >>>> ; Richardson, Bruce > >>>> ; shreyansh.jain@nxp.com; > >>>> gaetan.rivet@6wind.com; Burakov, Anatoly > >> ; > >>>> stephen@networkplumber.org; aconole@redhat.com; Santosh Shukla > >>>> > >>>> Subject: [PATCH v7 2/9] eal/pci: get iommu class > >>>> > >>>> Introducing rte_pci_get_iommu_class API which helps to get iommu > >>>> class of PCI device on the bus and returns preferred iova mapping > >>>> mode > >> for PCI bus. > >>>> Patch also add rte_pci_get_iommu_class definition for bsdapp, in > >>>> bsdapp case - api returns default iova mode. > >>>> > >>>> Signed-off-by: Santosh Shukla > > >>>> Signed-off-by: Jerin Jacob > >>>> Reviewed-by: Maxime Coquelin > >>>> --- > >>>> v6 --> v7: > >>>> - squashed v6 series patch [02/12] & [03/12] (Aaron comment). > >>>> > >>>> lib/librte_eal/bsdapp/eal/eal_pci.c | 10 ++++++++++ > >>>> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > >>>> lib/librte_eal/common/include/rte_bus.h | 10 ++++++++++ > >>>> lib/librte_eal/common/include/rte_pci.h | 11 +++++++++++ > >>>> 4 files changed, 32 insertions(+) > >>>> > >>>> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c > >>>> b/lib/librte_eal/bsdapp/eal/eal_pci.c > >>>> index 04eacdcc7..e2c252320 100644 > >>>> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > >>>> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > >>>> @@ -403,6 +403,16 @@ rte_pci_scan(void) > >>>> return -1; > >>>> } > >>>> > >>>> +/* > >>>> + * Get iommu class of pci devices on the bus. > >>>> + */ > >>>> +enum rte_iova_mode > >>>> +rte_pci_get_iommu_class(void) > >>>> +{ > >>>> + /* Supports only RTE_KDRV_NIC_UIO */ > >>>> + return RTE_IOVA_PA; > >>>> +} > >>>> + > >>>> int > >>>> pci_update_device(const struct rte_pci_addr *addr) { diff --git > >>>> a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > >>>> b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > >>>> index c819e3084..1fdcfb460 100644 > >>>> --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > >>>> +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > >>>> @@ -242,5 +242,6 @@ DPDK_17.11 { > >>>> global: > >>>> > >>>> rte_pci_match; > >>>> + rte_pci_get_iommu_class; > >>>> > >>>> } DPDK_17.08; > >>>> diff --git a/lib/librte_eal/common/include/rte_bus.h > >>>> b/lib/librte_eal/common/include/rte_bus.h > >>>> index c79368d3c..9e40687e5 100644 > >>>> --- a/lib/librte_eal/common/include/rte_bus.h > >>>> +++ b/lib/librte_eal/common/include/rte_bus.h > >>>> @@ -55,6 +55,16 @@ extern "C" { > >>>> /** Double linked list of buses */ TAILQ_HEAD(rte_bus_list, > >>>> rte_bus); > >>>> > >>>> + > >>>> +/** > >>>> + * IOVA mapping mode. > >>>> + */ > >>>> +enum rte_iova_mode { > >>>> + RTE_IOVA_DC =3D 0, /* Don't care mode */ > >>>> + RTE_IOVA_PA =3D (1 << 0), > >>>> + RTE_IOVA_VA =3D (1 << 1) > >>> Hi Santosh, > >>> > >>> No need to set values explicitly, standard C will take care of it. > >> no strong opinion, change queued for v8. >=20 > recalling myself on why expressed RTE_IOVA_PA/_VA as 1 << 0/1. > Since user in future (by mistake) may add new entry example: RTE_IOVA_XX > =3D 3 then it will enable both _pa and _va both, So to avoid such program= ming > error, deliberately kept _pa =3D 1 << 0 and _va =3D 1 << 1, if new entry = comes > (highly unlikely) then should be programmed as _xx =3D 1 << 2; >=20 > If you convinced then I think - i don;t need to spin this change for v8. Hi Santosh, Fair enough (on both issues). >=20 > >>> I wonder the purpose of "don't care" mode. It's not used for > >>> anything but > >> cases when no driver is bound. All the libraries (e.g. rte_malloc) > >> will only check for IOVA_VA mode. Can't we just used PA in all cases > >> where IOVA_DC would be applicable? > >> > >> Indeed policy is to use iova_pa for _dc case, but we need a way to > >> distinguish between no device found vs device attached (if attached > >> then decide upon its iova scheme). > >> > >> For more detailed info pl. refer [1]. > >> > >> [1] http://dpdk.org/dev/patchwork/patch/26762/ > >> > > Maybe make your intentions more explicit then? I.e. instead of "don't > care" use "no device" or some such. No strong opinion either way though, > I'm fine with leaving it as is. >=20 > prefer keeping _DC, if you don;t mind, sounds more appropriate to me. >=20 > > Thanks, > > Anatoly