From: Prashant Upadhyaya <prashant.upadhyaya@aricent.com>
To: Ivan Boule <ivan.boule@6wind.com>, Maxime Leroy <maxime.leroy@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS
Date: Wed, 20 Nov 2013 15:36:57 +0530 [thread overview]
Message-ID: <C7CE7EEF248E2B48BBA63D0ABEEE700C45DFDC35BC@GUREXMB01.ASIAN.AD.ARICENT.COM> (raw)
In-Reply-To: <528C85C3.3070607@6wind.com>
Hi,
So if I have multiple queues and was using ETH_MQ_RX_NONE (and therefore utilizing RSS), it will stop working for me now after this patch ?
Regards
-Prashant
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ivan Boule
Sent: Wednesday, November 20, 2013 3:20 PM
To: Maxime Leroy
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS
On 11/19/2013 02:03 PM, Maxime Leroy wrote:
> As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose
> between RSS, DCB or VMDQ modes for the selection of a rx queue.
>
> But the igb/ixgbe code always silently selects the RSS mode with
> ETH_MQ_RX_NONE. This patch fixes this incoherence between the API and
> the implementation.
>
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> ---
> lib/librte_pmd_e1000/igb_rxtx.c | 4 ++--
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_pmd_e1000/igb_rxtx.c
> b/lib/librte_pmd_e1000/igb_rxtx.c index f785d9f..641ceea 100644
> --- a/lib/librte_pmd_e1000/igb_rxtx.c
> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
> @@ -1745,8 +1745,6 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
> */
> if (dev->data->nb_rx_queues > 1)
> switch (dev->data->dev_conf.rxmode.mq_mode) {
> - case ETH_MQ_RX_NONE:
> - /* if mq_mode not assign, we use rss mode.*/
> case ETH_MQ_RX_RSS:
> igb_rss_configure(dev);
> break;
> @@ -1754,6 +1752,8 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
> /*Configure general VMDQ only RX parameters*/
> igb_vmdq_rx_hw_configure(dev);
> break;
> + case ETH_MQ_RX_NONE:
> + /* if mq_mode is none, disable rss mode.*/
> default:
> igb_rss_disable(dev);
> break;
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> index 0f7be95..e1b90f9 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> @@ -3217,8 +3217,6 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
> */
> if (dev->data->nb_rx_queues > 1)
> switch (dev->data->dev_conf.rxmode.mq_mode) {
> - case ETH_MQ_RX_NONE:
> - /* if mq_mode not assign, we use rss mode.*/
> case ETH_MQ_RX_RSS:
> ixgbe_rss_configure(dev);
> break;
> @@ -3231,6 +3229,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
> ixgbe_vmdq_rx_hw_configure(dev);
> break;
>
> + case ETH_MQ_RX_NONE:
> + /* if mq_mode is none, disable rss mode.*/
> default: ixgbe_rss_disable(dev);
> }
> else
Acked by Ivan Boule <ivan.boule@6wind.com>
--
Ivan Boule
6WIND Development Engineer
===============================================================================
Please refer to http://www.aricent.com/legal/email_disclaimer.html
for important disclosures regarding this electronic communication.
===============================================================================
next prev parent reply other threads:[~2013-11-20 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 13:03 Maxime Leroy
2013-11-19 13:03 ` [dpdk-dev] [PATCH 2/2] igb/ixgbe: allow RSS with only one Rx queue Maxime Leroy
2013-11-20 9:37 ` Ivan Boule
2013-11-20 9:57 ` Thomas Monjalon
2013-11-20 9:49 ` [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS Ivan Boule
2013-11-20 9:56 ` Thomas Monjalon
2013-11-20 10:06 ` Prashant Upadhyaya [this message]
2013-11-20 10:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C7CE7EEF248E2B48BBA63D0ABEEE700C45DFDC35BC@GUREXMB01.ASIAN.AD.ARICENT.COM \
--to=prashant.upadhyaya@aricent.com \
--cc=dev@dpdk.org \
--cc=ivan.boule@6wind.com \
--cc=maxime.leroy@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).