From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from jaguar.aricent.com (jaguar.aricent.com [121.241.96.11]) by dpdk.org (Postfix) with ESMTP id D105B6826 for ; Wed, 20 Nov 2013 11:06:18 +0100 (CET) Received: from jaguar.aricent.com (localhost [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id 3A93736B8D; Wed, 20 Nov 2013 15:36:58 +0530 (IST) Received: from GUREXHT01.ASIAN.AD.ARICENT.COM (gurexht01.asian.ad.aricent.com [10.203.171.136]) by jaguar.aricent.com (Postfix) with ESMTP id 2308A36B7E; Wed, 20 Nov 2013 15:36:58 +0530 (IST) Received: from GUREXMB01.asian.ad.aricent.com ([10.203.171.134]) by GUREXHT01.ASIAN.AD.ARICENT.COM ([10.203.171.136]) with mapi; Wed, 20 Nov 2013 15:36:58 +0530 From: Prashant Upadhyaya To: Ivan Boule , Maxime Leroy Date: Wed, 20 Nov 2013 15:36:57 +0530 Thread-Topic: [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS Thread-Index: Ac7l1dtA6l2VxB1wT/6iXSWThCYXDgAAiyAA Message-ID: References: <1384866215-18420-1-git-send-email-maxime.leroy@6wind.com> <528C85C3.3070607@6wind.com> In-Reply-To: <528C85C3.3070607@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-TM-AS-MML: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 10:06:19 -0000 Hi, So if I have multiple queues and was using ETH_MQ_RX_NONE (and therefore ut= ilizing RSS), it will stop working for me now after this patch ? Regards -Prashant -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ivan Boule Sent: Wednesday, November 20, 2013 3:20 PM To: Maxime Leroy Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disabl= e RSS On 11/19/2013 02:03 PM, Maxime Leroy wrote: > As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose > between RSS, DCB or VMDQ modes for the selection of a rx queue. > > But the igb/ixgbe code always silently selects the RSS mode with > ETH_MQ_RX_NONE. This patch fixes this incoherence between the API and > the implementation. > > Signed-off-by: Maxime Leroy > --- > lib/librte_pmd_e1000/igb_rxtx.c | 4 ++-- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_pmd_e1000/igb_rxtx.c > b/lib/librte_pmd_e1000/igb_rxtx.c index f785d9f..641ceea 100644 > --- a/lib/librte_pmd_e1000/igb_rxtx.c > +++ b/lib/librte_pmd_e1000/igb_rxtx.c > @@ -1745,8 +1745,6 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) > */ > if (dev->data->nb_rx_queues > 1) > switch (dev->data->dev_conf.rxmode.mq_mode) { > - case ETH_MQ_RX_NONE: > - /* if mq_mode not assign, we use rss mode.*/ > case ETH_MQ_RX_RSS: > igb_rss_configure(dev); > break; > @@ -1754,6 +1752,8 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) > /*Configure general VMDQ only RX parameters*/ > igb_vmdq_rx_hw_configure(dev); > break; > + case ETH_MQ_RX_NONE: > + /* if mq_mode is none, disable rss mode.*/ > default: > igb_rss_disable(dev); > break; > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index 0f7be95..e1b90f9 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -3217,8 +3217,6 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) > */ > if (dev->data->nb_rx_queues > 1) > switch (dev->data->dev_conf.rxmode.mq_mode) { > - case ETH_MQ_RX_NONE: > - /* if mq_mode not assign, we use rss mode.*/ > case ETH_MQ_RX_RSS: > ixgbe_rss_configure(dev); > break; > @@ -3231,6 +3229,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) > ixgbe_vmdq_rx_hw_configure(dev); > break; > > + case ETH_MQ_RX_NONE: > + /* if mq_mode is none, disable rss mode.*/ > default: ixgbe_rss_disable(dev); > } > else Acked by Ivan Boule -- Ivan Boule 6WIND Development Engineer =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D Please refer to http://www.aricent.com/legal/email_disclaimer.html for important disclosures regarding this electronic communication. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D