DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add mlx5 limitation of RSS hash result
Date: Thu, 16 Aug 2018 20:46:06 +0000	[thread overview]
Message-ID: <C8880ABF-48FE-4B2C-A57A-0CBE18C3CC5D@mellanox.com> (raw)
In-Reply-To: <20180814165747.16148-1-yskoh@mellanox.com>


> On Aug 14, 2018, at 9:57 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> doc/guides/nics/mlx5.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 52e1213cf5..cbcc233d03 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -136,6 +136,12 @@ Limitations
>   enabled (``rxq_cqe_comp_en``) at the same time, RSS hash result is not fully
>   supported. Some Rx packets may not have PKT_RX_RSS_HASH.
> 
> +- In general, PKT_RX_RSS_HASH shall be set in a received mbuf if RSS is enabled
> +  and the packet is subject to hash cacalculation. However, in case of
> +  vectorized Rx (``rx_vec_en``), PKT_RX_RSS_HASH will always be set as long as
> +  RSS is enabled. Zero hash result (mbuf->hash.rss) means the packet isn't
> +  subject to the configured RSS hash type and the flag should be disregarded.
> +
> Statistics
> ----------

I have to take it back.
We concluded there's a bug in the implementation and decided to fix this issue.

Thanks,
Yongseok

      reply	other threads:[~2018-08-16 20:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 16:57 Yongseok Koh
2018-08-16 20:46 ` Yongseok Koh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C8880ABF-48FE-4B2C-A57A-0CBE18C3CC5D@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).