From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by dpdk.org (Postfix) with ESMTP id 51E5D8D88 for ; Wed, 7 Oct 2015 15:37:32 +0200 (CEST) Received: by igcpe7 with SMTP id pe7so14530941igc.0 for ; Wed, 07 Oct 2015 06:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=aPqDIqslg1UlbIrKoHLsYKne46I9iIIxQSFTesK/8RM=; b=XFVq6xyH4pG8RLyns+1D8vIqya/KbH8RSCOO5zBRW/8tjx7ciHgR+HdG6gZ1bGj6WE 9UfFUZijNNjyVCMA/qcbeKzILG/mRxN5C/G/+RxJ9hnDQjOvTNlADU6nIq5/Kt+EyPjV P3P9e1i6qOKt2FllVxQanm+Jkfg3DBjmTYZiiLea4gjSXCt+9M6eFEoJ5itABcU2N9eC yuWeO683Rq1vx1TwDWQdm3RqGFcMuQi0BDzUdjCECwqj7breq5zln3W0QsBfbn+9tEw7 pMGuuODtqa/Xj2u5f22mBU6uNRhMqjz3FJQAW/Nh4NCvIaMLuA47By9PR5SXmv69FFwM LeHA== MIME-Version: 1.0 X-Received: by 10.50.171.161 with SMTP id av1mr1907889igc.6.1444225051789; Wed, 07 Oct 2015 06:37:31 -0700 (PDT) Received: by 10.79.109.22 with HTTP; Wed, 7 Oct 2015 06:37:31 -0700 (PDT) In-Reply-To: <20151006134819.GA7084@autoinstall.dev.6wind.com> References: <1440807373-24770-1-git-send-email-marc.sune@bisdn.de> <1443993167-1150-1-git-send-email-marcdevel@gmail.com> <1443993167-1150-4-git-send-email-marcdevel@gmail.com> <20151006134819.GA7084@autoinstall.dev.6wind.com> Date: Wed, 7 Oct 2015 15:37:31 +0200 Message-ID: From: Marc Sune To: =?UTF-8?Q?N=C3=A9lio_Laranjeiro?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 3/4] ethdev: redesign link speed config API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 13:37:32 -0000 2015-10-06 15:48 GMT+02:00 N=C3=A9lio Laranjeiro : > Hi Marc, > > On Sun, Oct 04, 2015 at 11:12:46PM +0200, Marc Sune wrote: > >[...] > > /** > > + * Device supported speeds bitmap flags > > + */ > > +#define ETH_LINK_SPEED_AUTONEG (0 << 0) /*< > Autonegociate (all speeds) */ > > +#define ETH_LINK_SPEED_NO_AUTONEG (1 << 0) /*< Disable autoneg > (fixed speed) */ > > +#define ETH_LINK_SPEED_10M_HD (1 << 1) /*< 10 Mbps > half-duplex */ > > +#define ETH_LINK_SPEED_10M (1 << 2) /*< 10 Mbps full-duplex > */ > > +#define ETH_LINK_SPEED_100M_HD (1 << 3) /*< 100 Mbps > half-duplex */ > > +#define ETH_LINK_SPEED_100M (1 << 4) /*< 100 Mbps full-duple= x > */ > > +#define ETH_LINK_SPEED_1G (1 << 5) /*< 1 Gbps */ > > +#define ETH_LINK_SPEED_2_5G (1 << 6) /*< 2.5 Gbps */ > > +#define ETH_LINK_SPEED_5G (1 << 7) /*< 5 Gbps */ > > +#define ETH_LINK_SPEED_10G (1 << 8) /*< 10 Mbps */ > > +#define ETH_LINK_SPEED_20G (1 << 9) /*< 20 Gbps */ > > +#define ETH_LINK_SPEED_25G (1 << 10) /*< 25 Gbps */ > > +#define ETH_LINK_SPEED_40G (1 << 11) /*< 40 Gbps */ > > +#define ETH_LINK_SPEED_50G (1 << 12) /*< 50 Gbps */ > > +#define ETH_LINK_SPEED_56G (1 << 13) /*< 56 Gbps */ > > +#define ETH_LINK_SPEED_100G (1 << 14) /*< 100 Gbps */ > > + > > +/** > > + * Ethernet numeric link speeds in Mbps > > + */ > > +#define ETH_SPEED_NUM_NONE 0 /*< Not defined */ > > +#define ETH_SPEED_NUM_10M 10 /*< 10 Mbps */ > > +#define ETH_SPEED_NUM_100M 100 /*< 100 Mbps */ > > +#define ETH_SPEED_NUM_1G 1000 /*< 1 Gbps */ > > +#define ETH_SPEED_NUM_2_5G 2500 /*< 2.5 Gbps */ > > +#define ETH_SPEED_NUM_5G 5000 /*< 5 Gbps */ > > +#define ETH_SPEED_NUM_10G 10000 /*< 10 Mbps */ > > +#define ETH_SPEED_NUM_20G 20000 /*< 20 Gbps */ > > +#define ETH_SPEED_NUM_25G 25000 /*< 25 Gbps */ > > +#define ETH_SPEED_NUM_40G 40000 /*< 40 Gbps */ > > +#define ETH_SPEED_NUM_50G 50000 /*< 50 Gbps */ > > +#define ETH_SPEED_NUM_56G 56000 /*< 56 Gbps */ > > +#define ETH_SPEED_NUM_100G 100000 /*< 100 Gbps */ > > + > > +/** > > * A structure used to retrieve link-level information of an Ethernet > port. > > */ > > struct rte_eth_link { > > - uint16_t link_speed; /**< ETH_LINK_SPEED_[10, 100, 1000, > 10000] */ > > - uint16_t link_duplex; /**< ETH_LINK_[HALF_DUPLEX, FULL_DUPLEX= ] > */ > > - uint8_t link_status : 1; /**< 1 -> link up, 0 -> link down */ > > -}__attribute__((aligned(8))); /**< aligned for atomic64 read/write > */ > > - > > -#define ETH_LINK_SPEED_AUTONEG 0 /**< Auto-negotiate link speed= . > */ > > -#define ETH_LINK_SPEED_10 10 /**< 10 megabits/second. */ > > -#define ETH_LINK_SPEED_100 100 /**< 100 megabits/second. */ > > -#define ETH_LINK_SPEED_1000 1000 /**< 1 gigabits/second. */ > > -#define ETH_LINK_SPEED_10000 10000 /**< 10 gigabits/second. */ > > -#define ETH_LINK_SPEED_10G 10000 /**< alias of 10 > gigabits/second. */ > > -#define ETH_LINK_SPEED_20G 20000 /**< 20 gigabits/second. */ > > -#define ETH_LINK_SPEED_40G 40000 /**< 40 gigabits/second. */ > > + uint32_t link_speed; /**< Link speed (ETH_SPEED_NUM_) */ > > + uint16_t link_duplex; /**< 1 -> full duplex, 0 -> half duple= x > */ > > + uint8_t link_autoneg : 1; /**< 1 -> link speed has been autoneg = */ > > + uint8_t link_status : 1; /**< 1 -> link up, 0 -> link down */ > > +} __attribute__((aligned(8))); /**< aligned for atomic64 > read/write */ > >[...] > > Pretty good. One question, why did you not merge link_duplex, autoneg, > and status like: > > struct rte_eth_link { > uint32_t link_speed; > uint32_t link_duplex:1; > uint32_t link_autoneg:1; > uint32_t link_status:1; > }; > > is it really useful to keep a uint16_t for the duplex alone? > You are right, I've missed this one. Will be fixed in v6. > > Another point, the comment about link_duplex field should point to the > defines you have changed i.e. ETH_LINK_HALF_DUPLEX, ETH_LINK_FULL_DUPLEX. > Right. Will do that as part of v6 + comments of Neil. Marc > Regards, > > -- > N=C3=A9lio Laranjeiro > 6WIND >