From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marcdevel@gmail.com>
Received: from mail-io0-f176.google.com (mail-io0-f176.google.com
 [209.85.223.176]) by dpdk.org (Postfix) with ESMTP id A4955376C
 for <dev@dpdk.org>; Sun, 13 Sep 2015 21:14:52 +0200 (CEST)
Received: by iofh134 with SMTP id h134so145568607iof.0
 for <dev@dpdk.org>; Sun, 13 Sep 2015 12:14:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=U2Y1kGi+T2+2E2Zg+eComo8hRZyRvEtxm4Ek4ShHyBg=;
 b=nDD4sYoaAmVZd853NjveYFkpbvnA0/mosiNypfx1B7HlSt8PaHOvIAXzp/9kLSQmy7
 s8HfroDiOJG7w6LW/S5ACMTZhMtmEymcV1qDntdJ4fvTc+o/ONwpgFCSMcHBcC0ln4Xg
 wdxEQFY21l3jYQX/JbD8q/4uSRJOsjxSNiaBV56LayPgCH6X/eb9WmTeO7pCTzpJY8Y+
 1IxhDvrMgrW5TJmhtgsxS6Dv7xM4oVAOLrz81UjwOwgUCTpWqiJcMpt7/zh+KFTDh1zZ
 9rU65hg1EaEo34ygeWcxC4jj1gMGU0fdRfcYV8KgDmqxXoS8jQXwppVtCXhf04RnYkWQ
 9Fmg==
MIME-Version: 1.0
X-Received: by 10.107.164.38 with SMTP id n38mr15624027ioe.66.1442171691876;
 Sun, 13 Sep 2015 12:14:51 -0700 (PDT)
Received: by 10.79.109.22 with HTTP; Sun, 13 Sep 2015 12:14:51 -0700 (PDT)
In-Reply-To: <2699193.9riTyGPe1z@xps13>
References: <20150909131037.GA25122@autoinstall.dev.6wind.com>
 <2699193.9riTyGPe1z@xps13>
Date: Sun, 13 Sep 2015 21:14:51 +0200
Message-ID: <CA+3n-TorPf4Kp3YsA3TpDpJ2pyqwQ_x3OVjA_2jm9_-q_8+uFA@mail.gmail.com>
From: Marc Sune <marcdevel@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/2] ethdev: add port speed capability
	bitmap
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Sep 2015 19:14:52 -0000

Thomas,

2015-09-09 15:33 GMT+02:00 Thomas Monjalon <thomas.monjalon@6wind.com>:

> 2015-09-09 15:10, N=C3=A9lio Laranjeiro:
> > I think V2 is better, maybe you can add a function to convert a single
> > bitmap value to the equivalent integer and get rid of ETH_SPEED_XXX
> macros.
> >
> > Thomas what is your opinion?
>
> Your proposal looks good Nelio.
>

I am confused, specially since you were the one advocating for having a
unified set of constants for speeds (discussion in v2).

In any case, as I see it, if we want to address the comments of  M. Brorup:

http://comments.gmane.org/gmane.comp.networking.dpdk.devel/19664

we need bitmaps for rte_eth_conf link_speed to set the advertised speeds.

 857 struct rte_eth_conf {

 858         uint16_t link_speed;

 859         /**< ETH_LINK_SPEED_10[0|00|000], or 0 for autonegotation */

 860         uint16_t link_duplex;

Let me know if you really want to come back to v2 or not.

Marc


> Thanks
>