From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8F6ECA04E6;
	Tue, 10 Nov 2020 10:03:39 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EF2CE2B9D;
	Tue, 10 Nov 2020 10:03:22 +0100 (CET)
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id A18A42B93
 for <dev@dpdk.org>; Tue, 10 Nov 2020 10:03:21 +0100 (CET)
Received: by mail-lf1-f65.google.com with SMTP id r9so2701537lfn.11
 for <dev@dpdk.org>; Tue, 10 Nov 2020 01:03:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=emumba-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=Ag/nGXHQoncwkPp78NK6Q1GxX8YznbEA2MPaSP4AefQ=;
 b=vy+Tn6YttWagQ7AClK9vNrop2iPokuKg4MnOI4NL/2LS6xngAYD2T8dL7yztmj2zde
 k2oNPetx/tM+MXUyz6hmVLhcegZRcQIAbYx2nP0GDOAICuQ6sYvKNPIL6T29Ybs2qYUi
 eZw9pcUmHijZg2Ox4mpNwUQsXMJsFKDHsZkUc/pBZ+PaAAthkxHUMJuY5zibqnoSIcEY
 /CrZi3kCHSHK4BdHLCWSW62llG1nyOYFF9p6tsIOS6/ZWOImGZOV3B3jo0pvqn+976E1
 NTZkSFih/KUy2YZA2wjZBUcOPb5pr5/55+1vBLbfAwPbob8BNVr3hFX6FF2z6YHqp3Dt
 dSaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Ag/nGXHQoncwkPp78NK6Q1GxX8YznbEA2MPaSP4AefQ=;
 b=uEXZ4fucMcKyWp0zhUL0OfHavmqbzEy78p2pEe0nOe8XjZbw498AFEf0E2ZM+xz24w
 W6vwNogr0o48ilYIzwuXqwYdUUtOsMlTFRV77gHr+lkynGaoThJd4J9YT3s3V60jVLHB
 Q/g6sCI1LGYhuKPKppL8lAML8QsID1XI17YhXeobdxiek2oAl9Zr7Zc+1de4r6HNUBcU
 +30PhmNrebN5i0YJ7cjH7c3rb1F0HxCLXGwjXx/S6oFiGvWwMx4vRKqBTqGYGuAB/Fbj
 EA8fsWmKJDYpJjAbTtY4VPbuw/OMF/+TmHXPaD6nsQDqcxm98H6hW428gNneibWrORQN
 FmTw==
X-Gm-Message-State: AOAM533l0yovDWp00EnBGNk3EvEEFSTkEPc8Edu1fJgkI8qwWuMU6Qv4
 aVRzKaDsxq7Fqk9BFZQTKhbfTNwGTf66iDnrdXKNew==
X-Google-Smtp-Source: ABdhPJwQHEwZI8j8RbKAyqBjvObcnHUIphmYDXjv8qnTPKVrIJZTgs5A7KYGReQnIX9hjeuzrHWbT8IPjCJ7bZ8ptT4=
X-Received: by 2002:a05:6512:3250:: with SMTP id
 c16mr3457469lfr.404.1604999000092; 
 Tue, 10 Nov 2020 01:03:20 -0800 (PST)
MIME-Version: 1.0
References: <20201029125339.30916-1-ibtisam.tariq@emumba.com>
 <CAJFAV8yFjkvUdj+-TuOe=mEX8G9fPZnG7nSR0ehci1_-Zq0pFQ@mail.gmail.com>
 <CA+8bGBvR_LB+4FJs+BqS+R+ZsBe=UuTW=y7gOLQWLb9UeYngMg@mail.gmail.com>
 <CA+8bGBsfVCO-qrBOjZYa8Ze+Aap3duDoLibkf6BNWu3RW4_wYw@mail.gmail.com>
 <CAJFAV8zEgU-Mpw9xWizXhP0Jr0OOvbqHEbDZd5dhngnTfr-EUA@mail.gmail.com>
 <CA+8bGBuJxoao=J79o7Pqw_S8yrXjBHGVCzsynbanBkhxamfCDA@mail.gmail.com>
 <CAJFAV8zJ2PGFbf4Cj1McpXbnmhmjJ-xDwcKPy_hPFskh=UcD=A@mail.gmail.com>
In-Reply-To: <CAJFAV8zJ2PGFbf4Cj1McpXbnmhmjJ-xDwcKPy_hPFskh=UcD=A@mail.gmail.com>
From: Ibtisam Tariq <ibtisam.tariq@emumba.com>
Date: Tue, 10 Nov 2020 14:03:08 +0500
Message-ID: <CA+8bGBtgOZFrW6Ym=Xnb0Eh1tcXygWqv2z_GmgyZ7Uduf_BcZg@mail.gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Kovacevic, Marko" <marko.kovacevic@intel.com>, 
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Pattan,
 Reshma" <reshma.pattan@intel.com>, 
 "Mcnamara, John" <john.mcnamara@intel.com>, 
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>, 
 "Singh, Jasvinder" <jasvinder.singh@intel.com>, "Xia,
 Chenbo" <chenbo.xia@intel.com>, 
 Maxime Coquelin <maxime.coquelin@redhat.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 1/8] examples/fips_validation: enhance
 getopt_long usage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks for explaining. I got it.
I will submit the patches with new updates.

On Tue, Nov 10, 2020 at 1:23 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Nov 10, 2020 at 7:10 AM Ibtisam Tariq <ibtisam.tariq@emumba.com> wrote:
> > IMHO, it cannot be moved to read_uint16 parser.
> > If we do, we can't verify that the user input value is greater than
> > UINT16 MAX or not on the overflow data.
> > > > +                       if (data_room_size == 0 ||
> > > > +                                       data_room_size > UINT16_MAX) {
> > > > +                               cryptodev_fips_validate_usage(prgname);
> > > > +                               return -EINVAL;
> > > > +                       }
> >
> > The temp variable:data_room_size is necessary to check the overflow of
> > the command line argument.
>
> The overflow check can go to a new read_uint16 parser, like what is
> done in other parsers in this example.
>
> int
> parser_read_uint32(uint32_t *value, char *p)
> {
>         uint64_t val = 0;
>         int ret = parser_read_uint64(&val, p);
>         if (ret < 0)
>                 return ret;
>         if (val > UINT32_MAX)
>                 return -EINVAL;
>         *value = val;
>         return 0;
> }
>
> The parser_read_uint16 caller can do any additional check, here test
> for 0 value.
>
>
> --
> David Marchand
>


-- 
- Ibtisam