From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28D1DA054D; Thu, 18 Feb 2021 11:47:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99E01160757; Thu, 18 Feb 2021 11:47:52 +0100 (CET) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mails.dpdk.org (Postfix) with ESMTP id 2617D160753 for ; Thu, 18 Feb 2021 11:47:52 +0100 (CET) Received: by mail-lj1-f170.google.com with SMTP id v6so3572993ljh.9 for ; Thu, 18 Feb 2021 02:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sa0P2XRugpgiMRCs+L17ISDmTGAP7CwdaQPtimI8I7o=; b=QXOIBB+Fd6n5Lo6gLWjQ9P4Vpg3olpChgGvNG5MUo5p+dmeM8/VmksoQjx69sH5NV1 ePhSSEvWKHYUjHXJpnCWISv1UMWXisEhPa8wGkelI1230agPP3ckDzo4MowkeatOebSu B7rq9d6pujOAhwQhkcHLGxLbtd1IE1NzWrRomS0SQBcgt4P09MkBSr6B6IVQ+H6Fimgx U50PYk5gqH0qY1C0sNlYw8OVfdsakY/YCbKrVkdAgEY2qwhSlbCzoXpb9zsyl6VSsNIg FLEVO6tIeOP7sI+VqNTsrmbmSJ4fZzf+fjN3o/QLD4PRs8LD5coWmP8pVKA8FtnKEAg1 yjKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sa0P2XRugpgiMRCs+L17ISDmTGAP7CwdaQPtimI8I7o=; b=ELu1C88uLaScePnn/zFUIL+N4up6QS3Z5XX4ndUVWbngQL0wtgo5m2wpqyeNR0+EGm mjRpmOPdrbhvDmEiPDzQs/YDqNdcyl+/Y/OqUoo/rm8sZCvt7VdDm424thiciaVBCxSf Cxs7WZxUz/lCJiD/+MKqTQ0a9RAznN8bsGuT9cTVDoZ5qtmZSMcMGbqDpay6dP1DAqvP C7nIrc+SJttzfYDpzEBHIIu7A9988WPe3rF7TZFKYZmw/Si1CfHCXwYnFKcWLhLSJvif E4cals5NFC+43eu2kwyneEnijaFdPVUXVfVQThr7LZMbPxI3si2LVkMkq7/AXIXa1Kqf aUAQ== X-Gm-Message-State: AOAM531ECDKfzNE9EzV965semEvkWKfd77s3P2ulqed/MWvchsSf7inx sX8fw5mZBlgT4w0U1Lu3Y18U8nH/Uqh79p9MYnDEdA== X-Google-Smtp-Source: ABdhPJygwES6Rpjc/0HxjvWKX3d7j7YiVW+iTg9rj3tglRN9OlKX0r/z0Yj9DNgyU1KuZ+O8qlK8ZC6hN5I0QHdg7es= X-Received: by 2002:a05:651c:206:: with SMTP id y6mr2461728ljn.54.1613645271717; Thu, 18 Feb 2021 02:47:51 -0800 (PST) MIME-Version: 1.0 References: <20210204073420.2421-1-ibtisam.tariq@emumba.com> In-Reply-To: From: Ibtisam Tariq Date: Thu, 18 Feb 2021 15:47:36 +0500 Message-ID: To: David Marchand Cc: Maxime Coquelin , "Xia, Chenbo" , Cristian Dumitrescu , "Singh, Jasvinder" , "Mcnamara, John" , "Pattan, Reshma" , "Ananyev, Konstantin" , "Kovacevic, Marko" , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, Thanks for the recommendation. In future, I will add a cover letter for a long patch set. If you want, I can submit the cover letter for this patch set too. On Thu, Feb 18, 2021 at 2:59 PM David Marchand wrote: > On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq > wrote: > > > > Instead of using getopt_long return value, strcmp was used to > > compare the input parameters with the struct option array. This > > patch get rid of all those strcmp by directly binding each longopt > > with an int enum. This is to improve readability and consistency in > > all examples. > > > > Bugzilla ID: 238 > > Cc: marko.kovacevic@intel.com > > > > Reported-by: David Marchand > > Signed-off-by: Ibtisam Tariq > > For such a series, please provide a cover letter, this is easier when > replying on the whole series (and for me when applying). > > > For the series, > Reviewed-by: David Marchand > > There are still some unaligned examples (flow_classify, ip_reassembly, > kni, l2fwd-crypto, l3fwd-power, multi_process/symmetric_mp, vpda, > vmdq, vmdq_dcb), but this series is a good cleanup as is for now. > > -- > David Marchand > > -- - Ibtisam