Hi Thomas,

On Mon, Mar 3, 2025 at 2:25 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> Hi,
>
> This is the related code:
>
> /**
>  * RTE_FLOW_ACTION_TYPE_OF_PUSH_MPLS
>  *
>  * Implements OFPAT_PUSH_MPLS ("push a new MPLS tag") as defined by the
>  * OpenFlow Switch Specification.
>  */
> struct rte_flow_action_of_push_mpls {
>     rte_be16_t ethertype; /**< EtherType. */
> };
>

 That is correct, it is related to the MPLS push action.

>
>

> > On Mon, Mar 3, 2025 at 8:02 AM Kishore Padmanabha
> > <kishore.padmanabha@broadcom.com> wrote:
> > >
> > > Hi,
> > >
> > > Anyone has any inputs on this. Or should I add new CLI commands in
> testpmd to support action for push MPLS tag.
>
> This action was designed as an OpenFlow implementation.
> Is what you require an OpenFlow spec?
> If yes, we may consider an update,
> if no, we should create a new action.
>
>  The openflow spec
https://opennetworking.org/wp-content/uploads/2014/10/openflow-switch-v1.5.1.pdf
has mention of the MPLS push action but it does not mention how to specify
how to configure the mpls label, TC and BOS.

> > >
> > > Thanks,
> > >
> > > Kishore
> > >
> > > From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
> > > Sent: Thursday, February 27, 2025 6:35 PM
> > > To: 'dev@dpdk.org' <dev@dpdk.org>
> > > Subject: MPLS Push action
> > >
> > > Hi,
> > >
> > > When MPLS push action is used, using testpmd action  of_push_mpls, it
> accepts the ethertype only. How do I specify the MPLS label and other
> fields for the MPLS header to be added ? In the doc, in section 7.2.3.7
> there is mention of OFXPMT_OFB_MPLS_LABEL and other MPLS fields, but I
> could not find that in dpdk implementation.
>
> What is this documentation?
> Please provide a link.
>
> The above label is only mentioned for match and it is documented in
https://opennetworking.org/wp-content/uploads/2014/10/openflow-switch-v1.5.1.pdf
section 7.2.3.7

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.