From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com
 [209.85.213.171]) by dpdk.org (Postfix) with ESMTP id 22004C824
 for <dev@dpdk.org>; Wed, 29 Apr 2015 13:56:59 +0200 (CEST)
Received: by igblo3 with SMTP id lo3so44847478igb.0
 for <dev@dpdk.org>; Wed, 29 Apr 2015 04:56:58 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=evgQgSaiEwf9ze7n85fh9F4YXM38s5RSETi7jBC3F8M=;
 b=IFb8c4FwJVL/IhHfg2FPUGLxSYHQtn0RtKLBFCy6Wxvwc/uFLFkCec2nLOfRVoeJ7X
 +O7V0bHu++vx7ApLOX2QFVWcPAPgTpwhPkm4GmYZruQiUxcJGbf8TiQ8NfDIYovVIkDc
 oHzajqoHkHUaqItH/p4+AFoNIGCA6oIvuEE5aVyeLb33b/g9UgR8Q+Nqt4dEeuOGWQX2
 xoPpi2mSA47Me6mpGO6JK1P4xVs/wlOtypFEhaILsv3xSYsv4LbH72Uxs2F/yXoq9MtU
 uCROlmaxtLfOBL/R/4Zj2rsvYOyUfGYh56V4FJ83n92k7pRpShfLsFY6Ox+T7/jyYrz4
 SL9A==
X-Gm-Message-State: ALoCoQkXxheuUK2eJQBttLgcLzf+tCASzDZYi1mJUh9i1uAZYg/FefYGvOfocCuTIMlQCuZXYKvM
MIME-Version: 1.0
X-Received: by 10.43.60.14 with SMTP id wq14mr3029759icb.60.1430308618450;
 Wed, 29 Apr 2015 04:56:58 -0700 (PDT)
Received: by 10.107.159.75 with HTTP; Wed, 29 Apr 2015 04:56:58 -0700 (PDT)
In-Reply-To: <5540C29A.9010708@redhat.com>
References: <1430306974-9618-1-git-send-email-huawei.xie@intel.com>
 <5540C29A.9010708@redhat.com>
Date: Wed, 29 Apr 2015 13:56:58 +0200
Message-ID: <CA+PrjLE9FqCR558ZPvk2fwJbmncMfDfTOFaSQYg93VK4wfQuQA@mail.gmail.com>
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: make vhost lockless enqueue
	configurable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2015 11:56:59 -0000

2015-04-29 13:38 GMT+02:00 Panu Matilainen <pmatilai@redhat.com>:
> On 04/29/2015 02:29 PM, Huawei Xie wrote:
>>
>> vhost enabled vSwitch could have their own thread-safe vring enqueue
>> policy.
>> Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for vhost lockless enqueue.
>> Turn it off by default.
>>
>> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
>> ---
>>   config/common_linuxapp        |  1 +
>>   lib/librte_vhost/vhost_rxtx.c | 24 +++++++++++++++++++++++-
>>   2 files changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/config/common_linuxapp b/config/common_linuxapp
>> index 0078dc9..7f59499 100644
>> --- a/config/common_linuxapp
>> +++ b/config/common_linuxapp
>> @@ -421,6 +421,7 @@ CONFIG_RTE_KNI_VHOST_DEBUG_TX=n
>>   #
>>   CONFIG_RTE_LIBRTE_VHOST=n
>>   CONFIG_RTE_LIBRTE_VHOST_USER=y
>> +CONFIG_RTE_LIBRTE_VHOST_LOCKLESS_ENQ=n
>>   CONFIG_RTE_LIBRTE_VHOST_DEBUG=n
[...]
>
> These things should be runtime configurable, not build options. Please do
> not assume everybody builds DPDK separately for each and every application
> that might ever be.

+1
Adding new build options must be exceptions and very well justified.