From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) by dpdk.org (Postfix) with ESMTP id 936FFC7CE for ; Wed, 29 Apr 2015 12:13:00 +0200 (CEST) Received: by obcux3 with SMTP id ux3so16242106obc.2 for ; Wed, 29 Apr 2015 03:12:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=BiCbkBxiulS7xoLzJSMpGw2GUGhoFF9HJY2MrzFBrkk=; b=Yv9TsX3M2u2aK91VMOUPGRQRwWSGhyOCtPjXgEAj5mIxU4uzw8zfOn+Tf/CG6a2vUm q3Xn9grP1Go3d3TpkghuPPLwFNEhqUpbExwSFu/cT1sjpHbpc/iUWXYLt4siSbJiZeOY 5cQ1GUTQjjGXaGuKS3zcOqLtEFunOUooAZs+kRD3CwA02648cWctpoWS4lKMEovuDIDn u/jKJ6sh1+Pcbzbos9ACb29KiJwTfFb7q5mGGG8cE9wQ3XK3hz56xIXJ6u9QaQTPY/D+ yrdsWVrvJvjuWeEzKZSoORdk0QKQ4Lvs/ssiWpRV0lTZseEAuQOfNorbO2eN4PXImWtj pciA== X-Gm-Message-State: ALoCoQmYO77SIGU1ZymLqyxBJGxJ37K+fv7vwsuksb0vXRvl8XNOq2D4nVYxrByHO++XQrunh+JH MIME-Version: 1.0 X-Received: by 10.60.94.72 with SMTP id da8mr517613oeb.32.1430302379825; Wed, 29 Apr 2015 03:12:59 -0700 (PDT) Received: by 10.76.112.203 with HTTP; Wed, 29 Apr 2015 03:12:59 -0700 (PDT) In-Reply-To: <1430240597-26782-1-git-send-email-keith.wiles@intel.com> References: <1430240597-26782-1-git-send-email-keith.wiles@intel.com> Date: Wed, 29 Apr 2015 12:12:59 +0200 Message-ID: From: Thomas Monjalon To: Keith Wiles Content-Type: text/plain; charset=ISO-8859-1 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Simplify the ifdefs in rte.app.mk. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 10:13:01 -0000 Hi Keith, Thanks for trying to improve maintainability. It seems this is the second version of your patch. Please add v2 prefix and a changelog to ease review and patch management. As you probably know, it is explained here: http://dpdk.org/dev#send 2015-04-28 19:03 GMT+02:00 Keith Wiles : > Trying to simplify the ifdefs in rte.app.mk to make the code > more readable and maintainable by moving LDLIBS variable to use > the same style as LDLIBS-y being used in the rest of the code. > > Added a new variable called EXTRA_LDLIBS to be used by example apps > instead of using LDLIBS directly. > > Signed-off-by: Keith Wiles