From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib: change rte_ring dequeue to guarantee ordering before tail update
Date: Sat, 23 Jul 2016 11:02:33 +0200 [thread overview]
Message-ID: <CA+PrjLGmaYppXVLR190Qn3B-JQVsvY1ZHGQexvKXs0_MOt8FmA@mail.gmail.com> (raw)
In-Reply-To: <20160723060515.GA13747@localhost.localdomain>
2016-07-23 8:05 GMT+02:00 Jerin Jacob <jerin.jacob@caviumnetworks.com>:
> On Thu, Jul 21, 2016 at 11:26:50PM +0200, Thomas Monjalon wrote:
>> > > Consumer queue dequeuing must be guaranteed to be done fully before the tail is updated. This is not guaranteed with a read barrier,
>> > > changed to a write barrier just before tail update which in practice guarantees correct order of reads and writes.
>> > >
>> > > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
>> >
>> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>>
>> Applied, thanks
>
> There was ongoing discussion on this
> http://dpdk.org/ml/archives/dev/2016-July/044168.html
Sorry Jerin, I forgot this email.
The problem is that nobody replied to your email and you did not nack
the v2 of this patch.
> This change may not be required as it has the performance impact.
We need to clearly understand what is the performance impact
(numbers and use cases) on one hand, and is there a real bug fixed
by this patch on the other hand?
Please guys make things clear and we'll revert if needed.
next prev parent reply other threads:[~2016-07-23 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 4:39 Juhamatti Kuusisaari
2016-07-15 12:22 ` Ananyev, Konstantin
2016-07-21 21:26 ` Thomas Monjalon
2016-07-23 6:05 ` Jerin Jacob
2016-07-23 9:02 ` Thomas Monjalon [this message]
2016-07-23 9:36 ` Jerin Jacob
2016-07-23 10:14 ` Ananyev, Konstantin
2016-07-23 10:38 ` Jerin Jacob
2016-07-23 11:15 ` Ananyev, Konstantin
2016-07-23 11:49 ` Jerin Jacob
2016-07-23 12:32 ` Ananyev, Konstantin
2016-07-23 12:35 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+PrjLGmaYppXVLR190Qn3B-JQVsvY1ZHGQexvKXs0_MOt8FmA@mail.gmail.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=juhamatti.kuusisaari@coriant.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).