From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mike.stolarchuk@bigswitch.com>
Received: from mail-yk0-f173.google.com (mail-yk0-f173.google.com
 [209.85.160.173]) by dpdk.org (Postfix) with ESMTP id 34F53B3D9
 for <dev@dpdk.org>; Mon,  7 Dec 2015 18:37:19 +0100 (CET)
Received: by ykdv3 with SMTP id v3so202886238ykd.0
 for <dev@dpdk.org>; Mon, 07 Dec 2015 09:37:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=bigswitch-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:date:message-id:subject:from:to:content-type;
 bh=mpkNJ1AmnTNCXmklmoAArhvJxqEwDdV5QaQfiO0eZXI=;
 b=wTR7L5ENPcW81kiFjMsp4ewhAVCFDsEUqIwRD+9sMkyDCpmwF8NuhJ5exK0Cc9l7wg
 CrQ6utC+tf1ONLVE9piubp0THFm3Y+L01qbUUpGd2OZDb/ArCYg5H4OoALVjEmzR9ou5
 4yRPerqKK3+tvXRzVXTqgqdnjYi/OxpdAwr8OdlRU6dTxhBvvHzkrL6XNsdU01YPQ1Js
 fEc77iliSd4npUEKc29lyX6lBBMsZJckq1F3/lVdddujiXt1jCvA6BsmBU5TTLvjiuIQ
 v0RDz+FAeSXQwxqnFSKQwxC7hB73lerJXCgFDcQCUjzC+SeQCiQZsZ3GLZz6i1ZbHaTU
 D+JA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:date:message-id:subject:from:to
 :content-type;
 bh=mpkNJ1AmnTNCXmklmoAArhvJxqEwDdV5QaQfiO0eZXI=;
 b=WtY+u9UbDHezRRKiDTJLIfqGnV8qesMegb62w2hLDTrNT8KXJSpijDA+6/+nfVlHNA
 YoNKpRjY09sJc+NkwiUnq3fGU2ukecDrZBaPCSm0eBmGpMBrbuNZTxENbQZb3hXCgpOM
 MzatM5Qs4nTk7eTPwnZwc4lUcenBFTyFAuC+SJkCeuUax5nmAVlNusoAOSTRZsnhTfhG
 QL1bW4p0RT/iTFp3CB18JmhUlxDgmq31+N7GI0x7L2T39U1U5oa3gyc+vBqJ/NPtGUSH
 cTKaKwYShF3eeSCaUGlDIogFxvXzQGMjfWnE6WXMbQ1oDWI/u+6f/MNFmot44ufeRfNL
 vdVg==
X-Gm-Message-State: ALoCoQlu0Cr0SjcCnTC49USerMvUZYD+wU3Hk6WVb2lAS/joe5sQ/p1zPZCIbtcyOnICXAGr4nHM
MIME-Version: 1.0
X-Received: by 10.129.4.150 with SMTP id 144mr22838438ywe.88.1449509838625;
 Mon, 07 Dec 2015 09:37:18 -0800 (PST)
Received: by 10.129.105.132 with HTTP; Mon, 7 Dec 2015 09:37:18 -0800 (PST)
Date: Mon, 7 Dec 2015 12:37:18 -0500
Message-ID: <CA+Qp4Xz-N9VckZ_3AjVedEZFZ1r9sO4C32Km+Aop-B4on+pXkw@mail.gmail.com>
From: Mike Stolarchuk <mike.stolarchuk@bigswitch.com>
To: dev@dpdk.org
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] Meaning of ETH_TXQ_FLAGS_NOREFCOUNT
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2015 17:37:19 -0000

Hello,

I would have thought that ETH_TXQ_FLAGS_NOREFCOUNT,
when enabled, would mean to ignore ref counts, as commented
in rte_ethdev.h:

#define ETH_TXQ_FLAGS_NOREFCOUNT 0x0002 /**< refcnt can be ignored */

But it seems to be used differently:

    if (!(txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT)) {
        for (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {
            rte_mempool_put(txep->mbuf->pool, txep->mbuf);
            txep->mbuf = NULL;
        }

So that if its -not- set, then rte_mempool_put() is called, and if it
is set then rte_pktmbuf_free_seg() is called.

Also, it seems to be used the same way in both the i40e driver
and the ixgbe driver:  when its set it decr's the refcount, when
its unset it ignores the refcnt, but these are the only two drivers
which seem to honor the flag.

Any chance of getting a little more information the intent here?

regards,
mts.