From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90E2BA034F; Mon, 7 Jun 2021 21:16:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ADCB4068B; Mon, 7 Jun 2021 21:16:41 +0200 (CEST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mails.dpdk.org (Postfix) with ESMTP id 6037940E78 for ; Thu, 3 Jun 2021 20:53:41 +0200 (CEST) Received: by mail-ej1-f42.google.com with SMTP id b9so10706262ejc.13 for ; Thu, 03 Jun 2021 11:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=SWzdnugdLYtGwbvVcPs6R0EXQEpWSzQyVcH1EesUOMo=; b=iNrDd/gyzT/3615nfVXwTOGHdhbE2Ovy1HX0jsfGU3EEXuD9JGruTAb29jYnrts3FH XqKUNXLCn0GOztREL7fSozKj228vlrAV2iC+99IhQ16G48Qab1XbceSlGx+yNUuth453 6RAdhVKHFY8FproiSxvc/ep59nNYDJonBBeG/INslPN34xfZCB0awN5I/RAiWQlLp2cK GZTQMwngtLu+78P0spc0dSYgdgKCa47k1uJnmi4bn+bGAajnHJaZa19i4iFPSt0x7jMV hjuBQfQeXNSAG+y82aRj5tRkXnCkALLUQHLIfowMDdbKqlVJGUFTfQGN7RcNDWvd8A8t G0+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=SWzdnugdLYtGwbvVcPs6R0EXQEpWSzQyVcH1EesUOMo=; b=Q7T03ehgsujf4+lAb9ModelkZxdRTnaCyJK+5sOAxMUB/cttviwDLY6OiodaFNhDao DdTsIX9BH4ZQyOV10kp86SZXzklPm3Saf2K5/UNvsgG5WDyIk6AX/E/XX6zqCccumHIe BR3/6A9Euyn5peSUCN9KnRxjiG/qvWHYO94XYBceQDVr5DKDmWJ4X50OpWCfiFM4x6Si Wh9bwJD50HG4fo8kg86hxjPTQjFUnxRlNK1HNVJU4KWxvFxbgS4z72pyaWFoY848CpkL y+JP97h/RKLWtsQ4vRqyTBG8mHpGYqZS7FP54ydNQQsaXGF9gwgsTlnveOY1eljjcNl+ U7Ig== X-Gm-Message-State: AOAM531n6lH87OTCv9WW2f9YkPMwahZMVz/bRD487zxKRmRiJW4l/KXV gsrmWu6/05/HFycmOQDFm3pBDD0Dqs8Wo4I5DFNvZVgwbms= X-Google-Smtp-Source: ABdhPJxZvIgNJKsTc+iV0GjYzzfIWKo2Kd0UNXckj/MwMowmZkLxVeQHddRFGwVlPslcvH20dxP8IHCxhxEMNIL8f5o= X-Received: by 2002:a17:906:6dc3:: with SMTP id j3mr713863ejt.448.1622746420674; Thu, 03 Jun 2021 11:53:40 -0700 (PDT) MIME-Version: 1.0 From: Cosmin Banu Date: Thu, 3 Jun 2021 21:53:29 +0300 Message-ID: To: dev@dpdk.org X-Mailman-Approved-At: Mon, 07 Jun 2021 21:16:40 +0200 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] memory leak reported by address sanitizer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, After a recent DPDK upgrade I noticed a memory leak on exit when running with address sanitizer: ================================================================= ==2260==ERROR: LeakSanitizer: detected memory leaks Direct leak of 3805032 byte(s) in 71 object(s) allocated from: #0 0x7fa6cffb6bc8 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dbc8) #1 0x55e4ee478a76 in pci_scan_one ../drivers/bus/pci/linux/pci.c:225 #2 0x55e4ee4795d5 in rte_pci_scan ../drivers/bus/pci/linux/pci.c:487 #3 0x55e4ee539552 in rte_bus_scan ../lib/librte_eal/common/eal_common_bus.c:50 #4 0x55e4ee566217 in rte_eal_init ../lib/librte_eal/linux/eal.c:1065 After a bit of digging, it looks like the issue is the following return statement: https://github.com/DPDK/dpdk/blob/v20.11/drivers/bus/pci/linux/pci.c#L335 The behavior changed in this commit: https://github.com/DPDK/dpdk/commit/c79a1c67465d0193b52e2ae4b64dd8362c575b2b The issue can be fixed by either freeing the memory, or adding the device: free(dev); // or rte_pci_add_device(dev); However, I don't know which is the correct behavior. I would appreciate any feedback. Thank you, Cosmin