On Sun, May 5, 2024 at 7:21 PM Stephen Hemminger wrote: > On Sat, 4 May 2024 19:18:37 +0000 > Abdullah Ömer Yamaç wrote: > > > clang-format is a tool to format C/C++/Objective-C code. It can be used > > to reformat code to match a given coding style, or to ensure that code > > adheres to a specific coding style. It helps to maintain a consistent > > coding style across the DPDK codebase. > > > > .clang-format file overrides the default style options provided by > > clang-format and large set of IDEs and text editors support it. > > > > Signed-off-by: Abdullah Ömer Yamaç > > Also, this looks wrong. The initialized arrays looked better before. > > > -static const char *tuntap_types[ETH_TUNTAP_TYPE_MAX] = { > - "UNKNOWN", "TUN", "TAP" > -}; > +static const char *tuntap_types[ETH_TUNTAP_TYPE_MAX] = {"UNKNOWN", "TUN", > "TAP"}; > > -static const char *valid_arguments[] = { > - ETH_TAP_IFACE_ARG, > - ETH_TAP_REMOTE_ARG, > - ETH_TAP_MAC_ARG, > - ETH_TAP_PERSIST_ARG, > - NULL > -}; > +static const char *valid_arguments[] = {ETH_TAP_IFACE_ARG, > ETH_TAP_REMOTE_ARG, ETH_TAP_MAC_ARG, > + ETH_TAP_PERSIST_ARG, NULL}; > I am confused about these variables. tuntap_types list values in a single line, but valid_arguments' values are listed separately. So, it is getting more complex to handle both of them. What should we do, do you have any idea?