From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7837F43FEB; Fri, 10 May 2024 05:09:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0D7F402D1; Fri, 10 May 2024 05:09:03 +0200 (CEST) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by mails.dpdk.org (Postfix) with ESMTP id 4C3D04025F for ; Fri, 10 May 2024 05:09:02 +0200 (CEST) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-23bd61fbd64so823988fac.0 for ; Thu, 09 May 2024 20:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715310541; x=1715915341; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iz/KVHc3IAA7gKSQ5/Y36MqczRziOLmoYDlh/qjIShk=; b=levWvnyVcISimKJ5IJ7kKlJ+yvl1BLotbmaU8Nw9bO2ZmzEP0zUfnJ3gdOxmi+/OFu 8uf/SvmgQHf3gZeaiX9Pz7Z/TaeqMVGXAGq09qBWyilu7uJZeVXePuMg+zYs6xKU52AX mebT7NEkyXuUBJVaYbqMYH89mvFVr14Odph47ShGm9V/Z78LsA4ZotgnE3nt9UFUvYDi rN6Vj9yIyAsDeVgkjqOAsgenqVUd0F7fBSDtBAq+cw6y0pzwVZkQN61x3soJ6K46Kq72 7QuN4VciANWMoig9mgjX5ntCHvIVEdz5Yu0j8nBpIq1bxThNNLDyS1oSrna4ryGlekUP tOSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715310541; x=1715915341; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iz/KVHc3IAA7gKSQ5/Y36MqczRziOLmoYDlh/qjIShk=; b=WM37h11TUwP3HcIcIIqfs1T91U0XgG2Y93NhY47b/GQgFlT8KWGkl8KPS/RYvGUiPK muG06HK6ByG2bxk5tC44yk9abaBPwouVREhr6doKjF2lAzKxWzCdOhH2lHhaA8DKckNN wxkNMsnqmuuSv61xjmpky7zuExb6QOte/RHIiB7m9BelehLL6OvKeYVOl0lfPUWN+LGn Xku+w4Vkog6yJn27w89XUnKOSX2vMKtPMSImWhQlrKGQ0gT7Mcfh/tcHfB0J4aEoUxlk wQZTWLjcUGoYpiS17ixUVOzvseNrqWDMwSqoIZBNDQOxTY+HS/R+9wwh75nI0ZS1gv1Q VaUg== X-Gm-Message-State: AOJu0YzxY56ot4sxAPUiejfO0HaowmDn+ukaB5BoBfUAMJ8GJ9rWwLil nf0an0TAaZknr1Kw9vaP0lLf5RJViMR/KSNXrcTL3iBmZBtTZVEJShDQKYc1Z5Ig4ydHVXepBmP 0N1zMCTCzSmAZFiLSQSYeS7QljqgZ7fbp X-Google-Smtp-Source: AGHT+IEPLWqAx4erX5PalHbP8sb2yuuP2dfpLX/3JEn4EIy8xkVmnYawMka7k9mFSZDAAm+IDq8dFJ+l9ihobxL0vYA= X-Received: by 2002:a05:6870:1583:b0:23d:286:a0b5 with SMTP id 586e51a60fabf-24172c0d1d2mr1688968fac.30.1715310541162; Thu, 09 May 2024 20:09:01 -0700 (PDT) MIME-Version: 1.0 References: <20240417133929.711268-1-aomeryamac@gmail.com> In-Reply-To: From: =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= Date: Fri, 10 May 2024 06:08:52 +0300 Message-ID: Subject: Re: [PATCH] lib/hash: setting the maximum reclamation size To: dev@dpdk.org Cc: dharmik.thakkar@arm.com, Honnappa Nagarahalli , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Thomas Monjalon Content-Type: multipart/alternative; boundary="0000000000007c52c6061810db00" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000007c52c6061810db00 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Is there any comment on this patch? On Tue, Apr 23, 2024 at 4:51=E2=80=AFPM Abdullah =C3=96mer Yama=C3=A7 wrote: > Hello, > Any comment on this patch? > > On Wed, Apr 17, 2024 at 4:39=E2=80=AFPM Abdullah =C3=96mer Yama=C3=A7 > wrote: > >> In the previous implementation, the maximum reclamation size was set >> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch >> uses the configuration argument to set the maximum reclamation size. >> >> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") >> Cc: dharmik.thakkar@arm.com >> Cc: Honnappa Nagarahalli >> Cc: Yipeng Wang >> Cc: Sameh Gobriel >> Cc: Bruce Richardson >> Cc: Vladimir Medvedkin >> >> Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 >> --- >> lib/hash/rte_cuckoo_hash.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c >> index 4a44aadd9a..6d80793164 100644 >> --- a/lib/hash/rte_cuckoo_hash.c >> +++ b/lib/hash/rte_cuckoo_hash.c >> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct >> rte_hash_rcu_config *cfg) >> if (params.size =3D=3D 0) >> params.size =3D total_entries; >> params.trigger_reclaim_limit =3D cfg->trigger_reclaim_li= mit; >> + params.max_reclaim_size =3D cfg->max_reclaim_size; >> if (params.max_reclaim_size =3D=3D 0) >> params.max_reclaim_size =3D >> RTE_HASH_RCU_DQ_RECLAIM_MAX; >> params.esize =3D sizeof(struct __rte_hash_rcu_dq_entry); >> -- >> 2.34.1 >> >> --0000000000007c52c6061810db00 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
Is there any comment on this patch?

On Tue, Apr 2= 3, 2024 at 4:51=E2=80=AFPM Abdullah =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com> wrote:
Hello,
An= y comment on this patch?

On Wed, Apr 17, 2024 at 4:39=E2=80=AFPM Abdullah = =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com> wrote:
In the previous implementation, the maximum rec= lamation size was set
to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
uses the configuration argument to set the maximum reclamation size.

Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")=
Cc: dharmik.th= akkar@arm.com
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>
Cc: Sameh Gobriel <sameh.gobriel@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 <aomeryamac@gmail.com>
---
=C2=A0lib/hash/rte_cuckoo_hash.c | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 4a44aadd9a..6d80793164 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_= hash_rcu_config *cfg)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (params.size =3D= =3D 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 params.size =3D total_entries;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 params.trigger_recl= aim_limit =3D cfg->trigger_reclaim_limit;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0params.max_reclaim_= size =3D cfg->max_reclaim_size;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (params.max_recl= aim_size =3D=3D 0)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 params.max_reclaim_size =3D RTE_HASH_RCU_DQ_RECLAIM_MAX;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 params.esize =3D si= zeof(struct __rte_hash_rcu_dq_entry);
--
2.34.1

--0000000000007c52c6061810db00--