From: Mats Liljegren <liljegren.mats2@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Mats Liljegren <mats.liljegren@enea.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] pcap: Fill in if_index field for rte_eth_dev_info_get()
Date: Tue, 21 Jan 2014 09:40:14 +0100 [thread overview]
Message-ID: <CA+xJJ18SG6Uw1MKCHO7+hteFhp6FCaN17HjzCbmVTJ1MbswO0A@mail.gmail.com> (raw)
In-Reply-To: <201401171848.52284.thomas.monjalon@6wind.com>
I can make new patches with the requested new titles. I found a
compiler warning caused by my code that I can remove at the same
time...
struct args_dict is found in rte_eth_pcap_arg_parser.h and is a
dictionary for command line parameters.
/Mats
On Fri, Jan 17, 2014 at 6:48 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> what about this title?
> "pcap: save if_index of the bound device"
>
>> From: Mats Liljegren <mats.liljegren@enea.com>
>>
>> Signed-off-by: Mats Liljegren <mats.liljegren@enea.com>
>
> Could you provide a little explanation, especially about struct args_dict ?
>
> The code seems OK.
> Thanks
> --
> Thomas
prev parent reply other threads:[~2014-01-21 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 13:42 [dpdk-dev] [PATCH v3 0/2] Introduce if_index field to struct rte_eth_dev_info liljegren.mats2
2014-01-09 13:42 ` [dpdk-dev] [PATCH v3 1/2] ethdev: " liljegren.mats2
2014-01-17 17:33 ` Thomas Monjalon
2014-01-09 13:42 ` [dpdk-dev] [PATCH v3 2/2] pcap: Fill in if_index field for rte_eth_dev_info_get() liljegren.mats2
2014-01-17 17:48 ` Thomas Monjalon
2014-01-21 8:40 ` Mats Liljegren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+xJJ18SG6Uw1MKCHO7+hteFhp6FCaN17HjzCbmVTJ1MbswO0A@mail.gmail.com \
--to=liljegren.mats2@gmail.com \
--cc=dev@dpdk.org \
--cc=mats.liljegren@enea.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).