From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <liljegren.mats2@gmail.com>
Received: from mail-ea0-x22c.google.com (mail-ea0-x22c.google.com
 [IPv6:2a00:1450:4013:c01::22c])
 by dpdk.org (Postfix) with ESMTP id CEE392F4
 for <dev@dpdk.org>; Tue, 21 Jan 2014 09:38:58 +0100 (CET)
Received: by mail-ea0-f172.google.com with SMTP id g15so2977400eak.31
 for <dev@dpdk.org>; Tue, 21 Jan 2014 00:40:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=5ng7loT3zg5s3yQZswpH/8SMwdz889TLgPgIpAmYuhw=;
 b=N/V4S4ZIK2kqMnY3l41SQZ9bar+tky3RGUCbh+lXSFE0s1OH5W2GMb5GYXhbAFslkS
 vy7Q1ZNbS7Lb/Sn7YF1V80pFLa3uy3LbIoTzkVdD7CEI5iZFrXz+bJmytuatMXkoy4cs
 +mPUt8qBiOIXuJDXf4rM08cOQ+f1uTkI4dE+mvYfVt8Eum6gGIqcM6LCSs/LrUAE5+qL
 PL3hhPE90SZazvIR2C1Lui7jgIN6uyxERK+9Ae4HfatYcjt+2p0yNAwUaKkVtTnopEir
 hwTmmO8IQfkqIitIBCFF2dR0ESgeHjJGCbEdCsAu8TiEA6uvUEHJy40miLyxrmdGQLbw
 1/6g==
MIME-Version: 1.0
X-Received: by 10.14.206.198 with SMTP id l46mr12384744eeo.35.1390293614493;
 Tue, 21 Jan 2014 00:40:14 -0800 (PST)
Received: by 10.15.94.5 with HTTP; Tue, 21 Jan 2014 00:40:14 -0800 (PST)
In-Reply-To: <201401171848.52284.thomas.monjalon@6wind.com>
References: <1389274977-53532-1-git-send-email-liljegren.mats2@gmail.com>
 <1389274977-53532-3-git-send-email-liljegren.mats2@gmail.com>
 <201401171848.52284.thomas.monjalon@6wind.com>
Date: Tue, 21 Jan 2014 09:40:14 +0100
Message-ID: <CA+xJJ18SG6Uw1MKCHO7+hteFhp6FCaN17HjzCbmVTJ1MbswO0A@mail.gmail.com>
From: Mats Liljegren <liljegren.mats2@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>, Mats Liljegren <mats.liljegren@enea.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] pcap: Fill in if_index field for
	rte_eth_dev_info_get()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jan 2014 08:38:59 -0000

I can make new patches with the requested new titles. I found a
compiler warning caused by my code that I can remove at the same
time...

struct args_dict is found in rte_eth_pcap_arg_parser.h and is a
dictionary for command line parameters.

/Mats

On Fri, Jan 17, 2014 at 6:48 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> what about this title?
> "pcap: save if_index of the bound device"
>
>> From: Mats Liljegren <mats.liljegren@enea.com>
>>
>> Signed-off-by: Mats Liljegren <mats.liljegren@enea.com>
>
> Could you provide a little explanation, especially about struct args_dict ?
>
> The code seems OK.
> Thanks
> --
> Thomas