From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-x229.google.com (mail-ee0-x229.google.com [IPv6:2a00:1450:4013:c00::229]) by dpdk.org (Postfix) with ESMTP id B22E558DF for ; Thu, 9 Jan 2014 09:42:53 +0100 (CET) Received: by mail-ee0-f41.google.com with SMTP id e53so94184eek.28 for ; Thu, 09 Jan 2014 00:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=gQXGqVcCfmCoy11vwfN17XDt9mHsUB9NIScHPNVw7ic=; b=OI+4GKXbO1xjbZFmsHsRyZIiCEqK744pQgUJ2gIsFPNBo2Y5lcZt26uqgM5ZWLEjTl +Kg9inQPEc0UeWPM4a7iN0uCZ4nH/HqEHwNX1siQyQKyCmjlvYuRbam5PhrfeM8XNdiy xDeas9+vR7khfqhbt8gap21neQXiZ/6UgY0BtpaUM3elvP8I+rq8WBIJPSDqPC7ogN/T DklT1V9ReRFofVRBkH8dOkjczQm8PxAeOMPV1CsqfkggfPAOvM96X8tB50bsBZNWknD2 PlAAqLjfN++4GxgsAqQ+KfxAk90CyFHiotSfBEewThZKgtAXBIcfSuHt54AVSrtiPDI7 B/kA== MIME-Version: 1.0 X-Received: by 10.14.199.197 with SMTP id x45mr2125192een.8.1389257045787; Thu, 09 Jan 2014 00:44:05 -0800 (PST) Received: by 10.15.94.5 with HTTP; Thu, 9 Jan 2014 00:44:05 -0800 (PST) In-Reply-To: References: Date: Thu, 9 Jan 2014 09:44:05 +0100 Message-ID: From: Mats Liljegren To: Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/2] Introduce if_index field to struct rte_eth_dev_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2014 08:42:54 -0000 On Thu, Jan 9, 2014 at 7:30 AM, Stephen Hemminger wrote: > Technically in Linux ifindex is unsigned 32 bit value. And 0 is > reserved as a marker. > Therefore why not use that semantic. > > On Wed, Jan 8, 2014 at 1:46 AM, Mats Liljegren > wrote: >> This field is intended for pcap to describe the name of the interface >> as known to Linux. It is an interface index, but can be translated into >> an interface name using if_indextoname() function. >> >> When using pcap, interrupt affinity becomes important, and this field >> gives the application a chance to ensure that interrupt affinity is set >> to the lcore handling the device. >> >> Signed-off-by: Mats Liljegren >> --- >> lib/librte_ether/rte_ethdev.c | 1 + >> lib/librte_ether/rte_ethdev.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 859ec92..38c1ea1 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -1037,6 +1037,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct >> rte_eth_dev_info *dev_info) >> /* Default device offload capabilities to zero */ >> dev_info->rx_offload_capa = 0; >> dev_info->tx_offload_capa = 0; >> + dev_info->if_index = -1; >> FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >> (*dev->dev_ops->dev_infos_get)(dev, dev_info); >> dev_info->pci_dev = dev->pci_dev; >> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >> index 302d378..5b80e5d 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -787,6 +787,7 @@ struct rte_eth_conf { >> struct rte_eth_dev_info { >> struct rte_pci_device *pci_dev; /**< Device PCI information. */ >> const char *driver_name; /**< Device Driver name. */ >> + int if_index; /**< Index to bounded host interface, or -1 if >> none. Use if_indextoname() to translate into an interface name. */ >> uint32_t min_rx_bufsize; /**< Minimum size of RX buffer. */ >> uint32_t max_rx_pktlen; /**< Maximum configurable length of RX pkt. */ >> uint16_t max_rx_queues; /**< Maximum number of RX queues. */ >> -- >> 1.8.3.2 You're right. I'm too used to int and -1... I'll prepare new patches.