* [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression
@ 2018-09-22 13:25 Fiona Trahe
2018-09-22 13:25 ` [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment Fiona Trahe
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fiona Trahe @ 2018-09-22 13:25 UTC (permalink / raw)
To: dev; +Cc: akhil.goyal, stable, Fiona Trahe
Checksum was always 0 on QAT decompression due to
incorrect use of union variable.
Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
Cc: stable@dpdk.org
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
drivers/compress/qat/qat_comp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index 38c8a5b..6f1f2dc 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -345,17 +345,16 @@ qat_comp_private_xform_create(struct rte_compressdev *dev,
if (xform->compress.deflate.huffman == RTE_COMP_HUFFMAN_FIXED ||
((xform->compress.deflate.huffman == RTE_COMP_HUFFMAN_DEFAULT)
&& qat->interm_buff_mz == NULL))
-
qat_xform->qat_comp_request_type =
QAT_COMP_REQUEST_FIXED_COMP_STATELESS;
+ qat_xform->checksum_type = xform->compress.chksum;
} else {
qat_xform->qat_comp_request_type = QAT_COMP_REQUEST_DECOMPRESS;
+ qat_xform->checksum_type = xform->decompress.chksum;
}
- qat_xform->checksum_type = xform->compress.chksum;
-
if (qat_comp_create_templates(qat_xform, qat->interm_buff_mz, xform)) {
QAT_LOG(ERR, "QAT: Problem with setting compression");
return -EINVAL;
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment
2018-09-22 13:25 [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression Fiona Trahe
@ 2018-09-22 13:25 ` Fiona Trahe
[not found] ` <9221f2b7-8737-369c-77e0-95e2a5daa1b2@nxp.com>
2018-09-27 11:48 ` Akhil Goyal
[not found] ` <fc4d4392-bbef-63f5-46f0-1ab86df6aae8@nxp.com>
2018-09-27 11:47 ` Akhil Goyal
2 siblings, 2 replies; 6+ messages in thread
From: Fiona Trahe @ 2018-09-22 13:25 UTC (permalink / raw)
To: dev; +Cc: akhil.goyal, stable, Fiona Trahe
Same variable was assigned twice, remove one.
Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
Cc: stable@dpdk.org
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
drivers/compress/qat/qat_comp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index 6f1f2dc..b9336f3 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -145,7 +145,6 @@ qat_comp_process_response(void **op, uint8_t *resp)
rx_op->debug_status =
*((uint16_t *)(&resp_msg->comn_resp.comn_error));
} else {
- struct qat_comp_xform *qat_xform = rx_op->private_xform;
struct icp_qat_fw_resp_comp_pars *comp_resp =
(struct icp_qat_fw_resp_comp_pars *)&resp_msg->comp_resp_pars;
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <9221f2b7-8737-369c-77e0-95e2a5daa1b2@nxp.com>]
* Re: [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment
[not found] ` <9221f2b7-8737-369c-77e0-95e2a5daa1b2@nxp.com>
@ 2018-09-27 11:29 ` Jozwiak, TomaszX
0 siblings, 0 replies; 6+ messages in thread
From: Jozwiak, TomaszX @ 2018-09-27 11:29 UTC (permalink / raw)
To: dev; +Cc: Akhil Goyal, stable, Trahe, Fiona
> -----Original Message-----
> From: Fiona Trahe <fiona.trahe@intel.com>
> Date: Sat, 22 Sep 2018 14:25:38 +0100
> Subject: [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary
> assignment
> To: dev@dpdk.org
> CC: akhil.goyal@nxp.com, stable@dpdk.org, Fiona Trahe
> <fiona.trahe@intel.com>
>
> Same variable was assigned twice, remove one.
>
> Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Acked-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment
2018-09-22 13:25 ` [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment Fiona Trahe
[not found] ` <9221f2b7-8737-369c-77e0-95e2a5daa1b2@nxp.com>
@ 2018-09-27 11:48 ` Akhil Goyal
1 sibling, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2018-09-27 11:48 UTC (permalink / raw)
To: Fiona Trahe, dev; +Cc: stable
On 9/22/2018 6:55 PM, Fiona Trahe wrote:
> Same variable was assigned twice, remove one.
>
> Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Applied to dpdk-next-crypto
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <fc4d4392-bbef-63f5-46f0-1ab86df6aae8@nxp.com>]
* Re: [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression
[not found] ` <fc4d4392-bbef-63f5-46f0-1ab86df6aae8@nxp.com>
@ 2018-09-27 11:25 ` Jozwiak, TomaszX
0 siblings, 0 replies; 6+ messages in thread
From: Jozwiak, TomaszX @ 2018-09-27 11:25 UTC (permalink / raw)
To: dev; +Cc: Akhil Goyal, Trahe, Fiona, stable
> -----Original Message-----
> From: Fiona Trahe <fiona.trahe@intel.com>
> Date: Sat, 22 Sep 2018 14:25:37 +0100
> Subject: [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on
> decompression
> To: dev@dpdk.org
> CC: akhil.goyal@nxp.com, stable@dpdk.org, Fiona Trahe
> <fiona.trahe@intel.com>
>
> Checksum was always 0 on QAT decompression due to incorrect use of union
> variable.
>
> Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Acked-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression
2018-09-22 13:25 [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression Fiona Trahe
2018-09-22 13:25 ` [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment Fiona Trahe
[not found] ` <fc4d4392-bbef-63f5-46f0-1ab86df6aae8@nxp.com>
@ 2018-09-27 11:47 ` Akhil Goyal
2 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2018-09-27 11:47 UTC (permalink / raw)
To: Fiona Trahe, dev; +Cc: stable
On 9/22/2018 6:55 PM, Fiona Trahe wrote:
> Checksum was always 0 on QAT decompression due to
> incorrect use of union variable.
>
> Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
>
Applied to dpdk-next-crypto
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-27 11:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-22 13:25 [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression Fiona Trahe
2018-09-22 13:25 ` [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment Fiona Trahe
[not found] ` <9221f2b7-8737-369c-77e0-95e2a5daa1b2@nxp.com>
2018-09-27 11:29 ` Jozwiak, TomaszX
2018-09-27 11:48 ` Akhil Goyal
[not found] ` <fc4d4392-bbef-63f5-46f0-1ab86df6aae8@nxp.com>
2018-09-27 11:25 ` [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression Jozwiak, TomaszX
2018-09-27 11:47 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).