From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3B6E1201 for ; Wed, 7 Nov 2018 11:18:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 02:18:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,475,1534834800"; d="scan'208";a="89239865" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 07 Nov 2018 02:18:51 -0800 Received: from lcsmsx155.ger.corp.intel.com (10.186.165.233) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 7 Nov 2018 02:18:51 -0800 Received: from hasmsx112.ger.corp.intel.com ([169.254.11.97]) by LCSMSX155.ger.corp.intel.com ([169.254.12.124]) with mapi id 14.03.0415.000; Wed, 7 Nov 2018 12:18:49 +0200 From: "Jozwiak, TomaszX" To: "Verma, Shally" , "dev@dpdk.org" , "Trahe, Fiona" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement Thread-Index: AQHUYhSjn5ZjkvYiqUCGRBSCtwq5y6U2CV0AgArVnACAAGXs8IABJz4AgAAtn8CAAE5/AIABWdKg Date: Wed, 7 Nov 2018 10:18:48 +0000 Message-ID: References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com> <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.104.14.176] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 10:18:54 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Tuesday, November 6, 2018 4:40 PM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; akhil.goyal@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance > measurement >=20 >=20 >=20 > >-----Original Message----- > >From: Jozwiak, TomaszX > >Sent: 06 November 2018 14:36 > >To: Verma, Shally ; dev@dpdk.org; Trahe, > Fiona > >; akhil.goyal@nxp.com > >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance > >measurement > > > >External Email > > > >> -----Original Message----- > >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] > >> Sent: Tuesday, November 6, 2018 9:16 AM > >> To: Jozwiak, TomaszX ; dev@dpdk.org; > >> Trahe, Fiona ; akhil.goyal@nxp.com > >> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add > >> performance measurement > ... >=20 > >> >> >> >+ > >> >> >> >+ /* Window size */ > >> >> >> >+ if (test_data->window_sz !=3D -1) { > >> >> >> >+ if (param_range_check(test_data->window_sz, > >> >> >> >+ &cap->window_size) > >> >> >> What if cap->window_size is 0 i.e. implementation default? > >> >> > > >> >> >TJ: You probably mean cap->window_size.increment =3D 0 (because > >> >> >cap->window_size is a structure). In that case we check if > >> >> >test_data->window_sz >=3Dmin and test_data->window_sz <=3D max > only, > >> >> because increment =3D 0 means (base on compression API) we have onl= y > >> >> one value of windows_size (no range is supported). > >> >> But PMD can set min and max too 0 for such case. > >> > > >> >TJ: I can't see any issue in that case too. Maybe I don't understand > >> >what you > >> mean but the logic is as follow: > >> >1) if you pass '--window-sz ...' param. into command line your > >> >intention is to force that value of window size during test. We > >> >check is this > >> value is allow (by param_range_check() function). > >> >2) if you plan to use default value - just don't pass '--window-sz' > >> >param. in command line at all. In that case we get windows size from > >> >window_size.max field, so if window_size.min=3D window_size.max=3D0 > >> test_data->window_sz will be zero, as well. > >> >If you mean that behavior is not good - I will be grateful for other > >> suggestions. > >> > >> This is fine. but I am thinking of 3rd case here: > >> c) user pass window sz but PMD window_sz.min =3D max =3D 0, then user > >> requested windowsz is not applicable right?! > > > >In that case - true. There'll be fail : > >"Compress device does not support this window size\n"); So what is your > >proposal for that case? > > > We can set to window size to implementation default and add in diagnostic > of used window sz for test run. > No need to fail here I believe. >=20 > Thanks > Shally Ok, I'll try to implement that feature in V3 Br, Tomek